Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2290233005: [gn] Port linux_use_bundled_binutils_override GN variable (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Dirk Pranke, Lei Zhang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Port linux_use_bundled_binutils_override GN variable Ports https://codereview.chromium.org/2293853002 to unblock deps roller. BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org NOTRY=true Committed: https://crrev.com/d4ec5f1c256e99ff7cedb55030a8291b5e5fabb0 Cr-Commit-Position: refs/heads/master@{#39034}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build_overrides/build.gni View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
Michael Achenbach
Blocks https://codereview.chromium.org/2293333002/
4 years, 3 months ago (2016-08-31 06:48:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290233005/1
4 years, 3 months ago (2016-08-31 06:48:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 06:50:21 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d4ec5f1c256e99ff7cedb55030a8291b5e5fabb0 Cr-Commit-Position: refs/heads/master@{#39034}
4 years, 3 months ago (2016-08-31 06:50:39 UTC) #10
Lei Zhang
lgtm https://codereview.chromium.org/2290233005/diff/1/build_overrides/build.gni File build_overrides/build.gni (right): https://codereview.chromium.org/2290233005/diff/1/build_overrides/build.gni#newcode20 build_overrides/build.gni:20: # Some non-Chromium builds don't use Chromium's third_party/binutils. ...
4 years, 3 months ago (2016-08-31 07:41:38 UTC) #12
Michael Achenbach
4 years, 3 months ago (2016-08-31 08:31:09 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2290233005/diff/1/build_overrides/build.gni
File build_overrides/build.gni (right):

https://codereview.chromium.org/2290233005/diff/1/build_overrides/build.gni#n...
build_overrides/build.gni:20: # Some non-Chromium builds don't use Chromium's
third_party/binutils.
On 2016/08/31 07:41:37, Lei Zhang wrote:
> This should say "V8 uses Chromium's third_party/binutils to speed up linking."

Hmm, yea - I didn't tidy any of the comments here. Feel free to change it. I
filed http://crbug.com/642641 for the general probelm.

Powered by Google App Engine
This is Rietveld 408576698