[turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

[turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=

Committed: https://crrev.com/f889230d59ec1d9a09130e82b841178a4f273b25
Cr-Commit-Position: refs/heads/master@{#39026}

[mvstanton, 2016-08-30 11:59:34]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 11:59:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-08-30 12:01:17]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org
- jarin@chromium.org

[mvstanton, 2016-08-30 12:01:17]

Hi Benedikt,
Here is step 2, thx for the look!
--Mike

[mvstanton, 2016-08-30 12:01:31]

Description was changed from

==========
[Turbofan]: Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
R=jarin@chromium.org
==========

to

==========
[Turbofan]: Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

[commit-bot: I haz the power, 2016-08-30 12:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:24:47]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-08-30 17:14:49]

Only nits, otherwise LGTM.

One general note: Can you use just [turbofan] for the subject/header line tag?
This would be more consistent with the other commit messages.

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc
File src/compiler/access-info.cc (right):

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc...
src/compiler/access-info.cc:300: MachineRepresentation rep =
MachineRepresentation::kTagged;
Nit: field_representation

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc...
src/compiler/access-info.cc:439: MachineRepresentation rep =
MachineRepresentation::kTagged;
Nit: field_representation

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc...
src/compiler/access-info.cc:491: MachineRepresentation rep =
MachineRepresentation::kTagged;
Nit: field_representation

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h
File src/compiler/access-info.h (right):

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h#...
src/compiler/access-info.h:97: MachineRepresentation representation() const {
return representation_; }
Nit: Can you rename to field_representation?

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h#...
src/compiler/access-info.h:107: MachineRepresentation representation, Type*
field_type,
Nit: Can you rename to field_representation?

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h#...
src/compiler/access-info.h:116: MachineRepresentation representation_;
Nit: Can you rename to field_representation_?

[mvstanton, 2016-08-30 17:46:22]

Description was changed from

==========
[Turbofan]: Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

to

==========
[Turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

[mvstanton, 2016-08-30 18:59:09]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[mvstanton, 2016-08-30 18:59:14]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-08-30 18:59:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2290233002/#ps20001
(title: "REBASE and comments.")

[commit-bot: I haz the power, 2016-08-30 18:59:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-08-30 18:59:34]

Thanks! Uploadin'...

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc
File src/compiler/access-info.cc (right):

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc...
src/compiler/access-info.cc:300: MachineRepresentation rep =
MachineRepresentation::kTagged;
On 2016/08/30 17:14:49, Benedikt Meurer wrote:
> Nit: field_representation

Done, but I had to rename the existing field_representation to
details_representation (since we are translating here from the Representation
type).

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc...
src/compiler/access-info.cc:439: MachineRepresentation rep =
MachineRepresentation::kTagged;
On 2016/08/30 17:14:49, Benedikt Meurer wrote:
> Nit: field_representation

Done.

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.cc...
src/compiler/access-info.cc:491: MachineRepresentation rep =
MachineRepresentation::kTagged;
On 2016/08/30 17:14:49, Benedikt Meurer wrote:
> Nit: field_representation

Done, but I had to rename the existing field_representation to
details_representation (since we are translating here from the Representation
type).

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h
File src/compiler/access-info.h (right):

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h#...
src/compiler/access-info.h:97: MachineRepresentation representation() const {
return representation_; }
On 2016/08/30 17:14:49, Benedikt Meurer wrote:
> Nit: Can you rename to field_representation?

Done.

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h#...
src/compiler/access-info.h:107: MachineRepresentation representation, Type*
field_type,
On 2016/08/30 17:14:49, Benedikt Meurer wrote:
> Nit: Can you rename to field_representation?

Done.

https://codereview.chromium.org/2290233002/diff/1/src/compiler/access-info.h#...
src/compiler/access-info.h:116: MachineRepresentation representation_;
On 2016/08/30 17:14:49, Benedikt Meurer wrote:
> Nit: Can you rename to field_representation_?

Done.

[mvstanton, 2016-08-30 19:00:52]

Description was changed from

==========
[Turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

to

==========
[turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

[commit-bot: I haz the power, 2016-08-30 19:25:11]

Description was changed from

==========
[turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

to

==========
[turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

[commit-bot: I haz the power, 2016-08-30 19:25:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 19:25:32]

Description was changed from

==========
[turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=
==========

to

==========
[turbofan] Introduce MachineRepresentation to PropertyAccessInfo.

Increasingly, we avoid using the representation dimension of Type,
  and set it explicitly ourselves.

BUG=

Committed: https://crrev.com/f889230d59ec1d9a09130e82b841178a4f273b25
Cr-Commit-Position: refs/heads/master@{#39026}
==========

[commit-bot: I haz the power, 2016-08-30 19:25:33]

Patchset 2 (id:??) landed as
https://crrev.com/f889230d59ec1d9a09130e82b841178a4f273b25
Cr-Commit-Position: refs/heads/master@{#39026}