Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: src/compiler/verifier.cc

Issue 2290233002: [turbofan] Introduce MachineRepresentation to PropertyAccessInfo. (Closed)
Patch Set: REBASE and comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/type-cache.h ('k') | src/machine-type.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 // Type is a number. 354 // Type is a number.
355 CheckTypeIs(node, Type::Number()); 355 CheckTypeIs(node, Type::Number());
356 break; 356 break;
357 case IrOpcode::kRelocatableInt32Constant: 357 case IrOpcode::kRelocatableInt32Constant:
358 case IrOpcode::kRelocatableInt64Constant: 358 case IrOpcode::kRelocatableInt64Constant:
359 CHECK_EQ(0, input_count); 359 CHECK_EQ(0, input_count);
360 break; 360 break;
361 case IrOpcode::kHeapConstant: 361 case IrOpcode::kHeapConstant:
362 // Constants have no inputs. 362 // Constants have no inputs.
363 CHECK_EQ(0, input_count); 363 CHECK_EQ(0, input_count);
364 // Type can be anything represented as a heap pointer.
365 CheckTypeIs(node, Type::TaggedPointer());
366 break; 364 break;
367 case IrOpcode::kExternalConstant: 365 case IrOpcode::kExternalConstant:
368 // Constants have no inputs. 366 // Constants have no inputs.
369 CHECK_EQ(0, input_count); 367 CHECK_EQ(0, input_count);
370 // Type is considered internal. 368 // Type is considered internal.
371 CheckTypeIs(node, Type::Internal()); 369 CheckTypeIs(node, Type::Internal());
372 break; 370 break;
373 case IrOpcode::kOsrValue: 371 case IrOpcode::kOsrValue:
374 // OSR values have a value and a control input. 372 // OSR values have a value and a control input.
375 CHECK_EQ(1, control_count); 373 CHECK_EQ(1, control_count);
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
854 case IrOpcode::kObjectIsReceiver: 852 case IrOpcode::kObjectIsReceiver:
855 case IrOpcode::kObjectIsSmi: 853 case IrOpcode::kObjectIsSmi:
856 case IrOpcode::kObjectIsString: 854 case IrOpcode::kObjectIsString:
857 case IrOpcode::kObjectIsUndetectable: 855 case IrOpcode::kObjectIsUndetectable:
858 case IrOpcode::kArrayBufferWasNeutered: 856 case IrOpcode::kArrayBufferWasNeutered:
859 CheckValueInputIs(node, 0, Type::Any()); 857 CheckValueInputIs(node, 0, Type::Any());
860 CheckTypeIs(node, Type::Boolean()); 858 CheckTypeIs(node, Type::Boolean());
861 break; 859 break;
862 case IrOpcode::kAllocate: 860 case IrOpcode::kAllocate:
863 CheckValueInputIs(node, 0, Type::PlainNumber()); 861 CheckValueInputIs(node, 0, Type::PlainNumber());
864 CheckTypeIs(node, Type::TaggedPointer());
865 break; 862 break;
866 case IrOpcode::kEnsureWritableFastElements: 863 case IrOpcode::kEnsureWritableFastElements:
867 CheckValueInputIs(node, 0, Type::Any()); 864 CheckValueInputIs(node, 0, Type::Any());
868 CheckValueInputIs(node, 1, Type::Internal()); 865 CheckValueInputIs(node, 1, Type::Internal());
869 CheckTypeIs(node, Type::Internal()); 866 CheckTypeIs(node, Type::Internal());
870 break; 867 break;
871 case IrOpcode::kMaybeGrowFastElements: 868 case IrOpcode::kMaybeGrowFastElements:
872 CheckValueInputIs(node, 0, Type::Any()); 869 CheckValueInputIs(node, 0, Type::Any());
873 CheckValueInputIs(node, 1, Type::Internal()); 870 CheckValueInputIs(node, 1, Type::Internal());
874 CheckValueInputIs(node, 2, Type::Unsigned31()); 871 CheckValueInputIs(node, 2, Type::Unsigned31());
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1011 case IrOpcode::kCheckString: 1008 case IrOpcode::kCheckString:
1012 CheckValueInputIs(node, 0, Type::Any()); 1009 CheckValueInputIs(node, 0, Type::Any());
1013 CheckTypeIs(node, Type::String()); 1010 CheckTypeIs(node, Type::String());
1014 break; 1011 break;
1015 case IrOpcode::kCheckIf: 1012 case IrOpcode::kCheckIf:
1016 CheckValueInputIs(node, 0, Type::Boolean()); 1013 CheckValueInputIs(node, 0, Type::Boolean());
1017 CheckNotTyped(node); 1014 CheckNotTyped(node);
1018 break; 1015 break;
1019 case IrOpcode::kCheckTaggedSigned: 1016 case IrOpcode::kCheckTaggedSigned:
1020 CheckValueInputIs(node, 0, Type::Any()); 1017 CheckValueInputIs(node, 0, Type::Any());
1021 CheckTypeIs(node, Type::TaggedSigned());
1022 break; 1018 break;
1023 case IrOpcode::kCheckTaggedPointer: 1019 case IrOpcode::kCheckTaggedPointer:
1024 CheckValueInputIs(node, 0, Type::Any()); 1020 CheckValueInputIs(node, 0, Type::Any());
1025 CheckTypeIs(node, Type::TaggedPointer());
1026 break; 1021 break;
1027 1022
1028 case IrOpcode::kCheckedInt32Add: 1023 case IrOpcode::kCheckedInt32Add:
1029 case IrOpcode::kCheckedInt32Sub: 1024 case IrOpcode::kCheckedInt32Sub:
1030 case IrOpcode::kCheckedInt32Div: 1025 case IrOpcode::kCheckedInt32Div:
1031 case IrOpcode::kCheckedInt32Mod: 1026 case IrOpcode::kCheckedInt32Mod:
1032 case IrOpcode::kCheckedUint32Div: 1027 case IrOpcode::kCheckedUint32Div:
1033 case IrOpcode::kCheckedUint32Mod: 1028 case IrOpcode::kCheckedUint32Mod:
1034 case IrOpcode::kCheckedInt32Mul: 1029 case IrOpcode::kCheckedInt32Mul:
1035 case IrOpcode::kCheckedUint32ToInt32: 1030 case IrOpcode::kCheckedUint32ToInt32:
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
1586 replacement->op()->EffectOutputCount() > 0); 1581 replacement->op()->EffectOutputCount() > 0);
1587 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1582 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1588 replacement->opcode() == IrOpcode::kFrameState); 1583 replacement->opcode() == IrOpcode::kFrameState);
1589 } 1584 }
1590 1585
1591 #endif // DEBUG 1586 #endif // DEBUG
1592 1587
1593 } // namespace compiler 1588 } // namespace compiler
1594 } // namespace internal 1589 } // namespace internal
1595 } // namespace v8 1590 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/type-cache.h ('k') | src/machine-type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698