Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: runtime/lib/mirrors.cc

Issue 22902002: Ensure the classes void and dynamic have empty arrays for fields, functions, etc. Move their Types … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: remove redudant mirror asserts, fix test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index d0e4524e01cac94453ac7a1f6c78580271a715f7..d75901a69bcb3c865323e9a94e3fb6aee3d6688f 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -461,15 +461,9 @@ DEFINE_NATIVE_ENTRY(ClassMirror_members, 2) {
}
const Array& fields = Array::Handle(klass.fields());
- // Some special types like 'dynamic' have a null fields list, but they should
- // not wind up as the reflectees of ClassMirrors.
- ASSERT(!fields.IsNull());
const intptr_t num_fields = fields.Length();
const Array& functions = Array::Handle(klass.functions());
- // Some special types like 'dynamic' have a null functions list, but they
- // should not wind up as the reflectees of ClassMirrors.
- ASSERT(!functions.IsNull());
const intptr_t num_functions = functions.Length();
Instance& member_mirror = Instance::Handle();
@@ -511,9 +505,6 @@ DEFINE_NATIVE_ENTRY(ClassMirror_constructors, 2) {
}
const Array& functions = Array::Handle(klass.functions());
- // Some special types like 'dynamic' have a null functions list, but they
- // should not wind up as the reflectees of ClassMirrors.
- ASSERT(!functions.IsNull());
const intptr_t num_functions = functions.Length();
Instance& constructor_mirror = Instance::Handle();
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698