Ensure the classes void and dynamic have empty arrays for fields, functions, etc. Move their Types …

Ensure the classes void and dynamic have empty arrays for fields, functions, etc. Move their Types to the VM isolate, and as a side-effect they are now canonicalized.

BUG=http://dartbug.com/12071
BUG=http://dartbug.com/12246
R=asiva@google.com, iposva@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26043

[regis, 2013-08-12 21:16:22]

LGTM

https://codereview.chromium.org/22902002/diff/3002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/22902002/diff/3002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:579: dynamic_type_ = type.raw();
Do you need the type handle? How about:
dynamic_type_ = Type::NewNonParameterizedType(cls);

https://codereview.chromium.org/22902002/diff/3002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:583: void_type_ = type.raw();
void_type_ = Type::NewNonParameterizedType(cls);

[Ivan Posva, 2013-08-12 21:42:25]

LGTM -ip

[rmacnak, 2013-08-12 22:14:43]

https://codereview.chromium.org/22902002/diff/3002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/22902002/diff/3002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:579: dynamic_type_ = type.raw();
On 2013/08/12 21:16:22, regis wrote:
> Do you need the type handle? How about:
> dynamic_type_ = Type::NewNonParameterizedType(cls);

Fixed.

[rmacnak, 2013-08-12 22:53:12]

Mark dart2js as failing dynamic_test.

[regis, 2013-08-12 23:01:14]

LGTM

[siva, 2013-08-12 23:50:53]

You had some null checks in the mirrors code to deal with
dynamic/void class etc. You should be able to remove them
now right...

[rmacnak, 2013-08-12 23:56:24]

Remove redundant non-null array asserts in mirrors. Fix copy-paste error in
test.

[siva, 2013-08-13 00:10:14]

lgtm

[rmacnak, 2013-08-13 00:11:51]

Committed patchset #5 manually as r26043 (presubmit successful).