Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2290083002: The preedit view of the candidate window should be hidden correctly when the text input client does… (Closed)

Created:
4 years, 3 months ago by Shu Chen
Modified:
4 years, 3 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The preedit view of the candidate window should be hidden correctly when the text input client doesn't support inline composing. BUG=612642 Committed: https://crrev.com/2820bbca0e3e9fa68df28eb4831e8d0471926aac Cr-Commit-Position: refs/heads/master@{#415225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Shu Chen
Lan, can you please review this cl? Thanks!
4 years, 3 months ago (2016-08-30 05:06:52 UTC) #2
Azure Wei
lgtm
4 years, 3 months ago (2016-08-30 05:23:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290083002/1
4 years, 3 months ago (2016-08-30 05:29:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:30:17 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:33:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2820bbca0e3e9fa68df28eb4831e8d0471926aac
Cr-Commit-Position: refs/heads/master@{#415225}

Powered by Google App Engine
This is Rietveld 408576698