Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: ui/base/ime/input_method_chromeos.cc

Issue 2290083002: The preedit view of the candidate window should be hidden correctly when the text input client does… (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_chromeos.cc
diff --git a/ui/base/ime/input_method_chromeos.cc b/ui/base/ime/input_method_chromeos.cc
index 4de4db2dfbc0c272a34c8030e152a5ef7cd20635..53ee44940d17c19cf469955cef3cd65e4951546d 100644
--- a/ui/base/ime/input_method_chromeos.cc
+++ b/ui/base/ime/input_method_chromeos.cc
@@ -457,6 +457,11 @@ void InputMethodChromeOS::CommitText(const std::string& text) {
if (utf16_text.empty())
return;
+ if (!CanComposeInline()) {
+ // Hides the candidate window for preedit text.
+ UpdateCompositionText(CompositionText(), 0, false);
+ }
+
// Append the text to the buffer, because commit signal might be fired
// multiple times when processing a key event.
result_text_.append(utf16_text);
« no previous file with comments | « chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698