Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2289973002: Remove unneeded pipeline barrier in vulkan (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unneeded pipeline barrier in vulkan We don't need to syncronize the mapped memory writes to the buffer since all CPU writes are already syncronized when we submit a command buffer. And we are using coherent memory for buffers so we don't need to call vkFlushMappedMemory BUG=skia: Committed: https://skia.googlesource.com/skia/+/f5f97dd7ab0a9d7cf781a8457926f9d48f4b637e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
4 years, 3 months ago (2016-08-29 20:09:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289973002/1
4 years, 3 months ago (2016-08-29 20:09:52 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-29 20:09:54 UTC) #6
jvanverth1
lgtm
4 years, 3 months ago (2016-08-29 20:24:30 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 20:42:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f5f97dd7ab0a9d7cf781a8457926f9d48f4b637e

Powered by Google App Engine
This is Rietveld 408576698