Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: src/gpu/vk/GrVkGpu.cpp

Issue 2289973002: Remove unneeded pipeline barrier in vulkan (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/vk/GrVkGpu.cpp
diff --git a/src/gpu/vk/GrVkGpu.cpp b/src/gpu/vk/GrVkGpu.cpp
index 495b85e7311887e12fe8b2cd08e3ba9a1299dfa3..91da82d945888629775663209971c7aae5a9e8d2 100644
--- a/src/gpu/vk/GrVkGpu.cpp
+++ b/src/gpu/vk/GrVkGpu.cpp
@@ -1153,27 +1153,6 @@ GrBackendObject GrVkGpu::createTestingOnlyBackendTexture(void* srcData, int w, i
1, &barrier));
initialLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL;
- // Make sure buffer has finished the unmap
- VkBufferMemoryBarrier bufBarrier;
- memset(&barrier, 0, sizeof(VkImageMemoryBarrier));
- bufBarrier.sType = VK_STRUCTURE_TYPE_BUFFER_MEMORY_BARRIER;
- bufBarrier.pNext = nullptr;
- bufBarrier.srcAccessMask = VK_ACCESS_HOST_WRITE_BIT;
- bufBarrier.dstAccessMask = VK_ACCESS_TRANSFER_READ_BIT;
- bufBarrier.srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED;
- bufBarrier.dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED;
- bufBarrier.buffer = buffer;
- bufBarrier.offset = 0;
- bufBarrier.size = bufInfo.size;
-
- VK_CALL(CmdPipelineBarrier(cmdBuffer,
- VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
- VK_PIPELINE_STAGE_TRANSFER_BIT,
- 0,
- 0, nullptr,
- 1, &bufBarrier,
- 0, nullptr));
-
// Submit copy command
VkBufferImageCopy region;
memset(&region, 0, sizeof(VkBufferImageCopy));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698