Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 2289793003: Revert of [css-flexbox] align-content should apply even when there's just a single line (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-content.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1735 matching lines...) Expand 10 before | Expand all | Expand 10 after
1746 setFlowAwareLocationForChild(*child, LayoutPoint(mainAxisOffset, crossAx isOffset + flowAwareMarginBeforeForChild(*child))); 1746 setFlowAwareLocationForChild(*child, LayoutPoint(mainAxisOffset, crossAx isOffset + flowAwareMarginBeforeForChild(*child)));
1747 1747
1748 mainAxisOffset -= flowAwareMarginStartForChild(*child); 1748 mainAxisOffset -= flowAwareMarginStartForChild(*child);
1749 1749
1750 ++seenInFlowPositionedChildren; 1750 ++seenInFlowPositionedChildren;
1751 if (seenInFlowPositionedChildren < numberOfChildrenForJustifyContent) 1751 if (seenInFlowPositionedChildren < numberOfChildrenForJustifyContent)
1752 mainAxisOffset -= justifyContentSpaceBetweenChildren(availableFreeSp ace, distribution, numberOfChildrenForJustifyContent); 1752 mainAxisOffset -= justifyContentSpaceBetweenChildren(availableFreeSp ace, distribution, numberOfChildrenForJustifyContent);
1753 } 1753 }
1754 } 1754 }
1755 1755
1756 static LayoutUnit initialAlignContentOffset(LayoutUnit availableFreeSpace, Conte ntPosition alignContent, ContentDistributionType alignContentDistribution, bool isMultiline, unsigned numberOfLines) 1756 static LayoutUnit initialAlignContentOffset(LayoutUnit availableFreeSpace, Conte ntPosition alignContent, ContentDistributionType alignContentDistribution, unsig ned numberOfLines)
1757 { 1757 {
1758 if (!isMultiline) 1758 if (numberOfLines <= 1)
1759 return LayoutUnit(); 1759 return LayoutUnit();
1760 if (alignContent == ContentPositionFlexEnd) 1760 if (alignContent == ContentPositionFlexEnd)
1761 return availableFreeSpace; 1761 return availableFreeSpace;
1762 if (alignContent == ContentPositionCenter) 1762 if (alignContent == ContentPositionCenter)
1763 return availableFreeSpace / 2; 1763 return availableFreeSpace / 2;
1764 if (alignContentDistribution == ContentDistributionSpaceAround) { 1764 if (alignContentDistribution == ContentDistributionSpaceAround) {
1765 if (availableFreeSpace > 0 && numberOfLines) 1765 if (availableFreeSpace > 0 && numberOfLines)
1766 return availableFreeSpace / (2 * numberOfLines); 1766 return availableFreeSpace / (2 * numberOfLines);
1767 if (availableFreeSpace < 0) 1767 if (availableFreeSpace < 0)
1768 return availableFreeSpace / 2; 1768 return availableFreeSpace / 2;
1769 } 1769 }
1770 return LayoutUnit(); 1770 return LayoutUnit();
1771 } 1771 }
1772 1772
1773 static LayoutUnit alignContentSpaceBetweenChildren(LayoutUnit availableFreeSpace , ContentDistributionType alignContentDistribution, unsigned numberOfLines) 1773 static LayoutUnit alignContentSpaceBetweenChildren(LayoutUnit availableFreeSpace , ContentDistributionType alignContentDistribution, unsigned numberOfLines)
1774 { 1774 {
1775 if (availableFreeSpace > 0 && numberOfLines > 1) { 1775 if (availableFreeSpace > 0 && numberOfLines > 1) {
1776 if (alignContentDistribution == ContentDistributionSpaceBetween) 1776 if (alignContentDistribution == ContentDistributionSpaceBetween)
1777 return availableFreeSpace / (numberOfLines - 1); 1777 return availableFreeSpace / (numberOfLines - 1);
1778 if (alignContentDistribution == ContentDistributionSpaceAround || alignC ontentDistribution == ContentDistributionStretch) 1778 if (alignContentDistribution == ContentDistributionSpaceAround || alignC ontentDistribution == ContentDistributionStretch)
1779 return availableFreeSpace / numberOfLines; 1779 return availableFreeSpace / numberOfLines;
1780 } 1780 }
1781 return LayoutUnit(); 1781 return LayoutUnit();
1782 } 1782 }
1783 1783
1784 void LayoutFlexibleBox::alignFlexLines(Vector<LineContext>& lineContexts) 1784 void LayoutFlexibleBox::alignFlexLines(Vector<LineContext>& lineContexts)
1785 { 1785 {
1786 if (!lineContexts.size())
1787 return;
1788
1789 ContentPosition position = styleRef().resolvedAlignContentPosition(contentAl ignmentNormalBehavior()); 1786 ContentPosition position = styleRef().resolvedAlignContentPosition(contentAl ignmentNormalBehavior());
1790 ContentDistributionType distribution = styleRef().resolvedAlignContentDistri bution(contentAlignmentNormalBehavior()); 1787 ContentDistributionType distribution = styleRef().resolvedAlignContentDistri bution(contentAlignmentNormalBehavior());
1791 1788
1792 // If we have a single line flexbox the line height is all the available spa ce. 1789 // If we have a single line flexbox or a multiline line flexbox with only on e flex line,
1790 // the line height is all the available space.
1793 // For flex-direction: row, this means we need to use the height, so we do t his after calling updateLogicalHeight. 1791 // For flex-direction: row, this means we need to use the height, so we do t his after calling updateLogicalHeight.
1794 if (!isMultiline()) { 1792 if (lineContexts.size() == 1) {
1795 lineContexts[0].crossAxisExtent = crossAxisContentExtent(); 1793 lineContexts[0].crossAxisExtent = crossAxisContentExtent();
1796 return; 1794 return;
1797 } 1795 }
1798 1796
1799 if (position == ContentPositionFlexStart) 1797 if (position == ContentPositionFlexStart)
1800 return; 1798 return;
1801 1799
1802 LayoutUnit availableCrossAxisSpace = crossAxisContentExtent(); 1800 LayoutUnit availableCrossAxisSpace = crossAxisContentExtent();
1803 for (size_t i = 0; i < lineContexts.size(); ++i) 1801 for (size_t i = 0; i < lineContexts.size(); ++i)
1804 availableCrossAxisSpace -= lineContexts[i].crossAxisExtent; 1802 availableCrossAxisSpace -= lineContexts[i].crossAxisExtent;
1805 1803
1806 LayoutBox* child = m_orderIterator.first(); 1804 LayoutBox* child = m_orderIterator.first();
1807 LayoutUnit lineOffset = initialAlignContentOffset(availableCrossAxisSpace, p osition, distribution, isMultiline(), lineContexts.size()); 1805 LayoutUnit lineOffset = initialAlignContentOffset(availableCrossAxisSpace, p osition, distribution, lineContexts.size());
1808 for (unsigned lineNumber = 0; lineNumber < lineContexts.size(); ++lineNumber ) { 1806 for (unsigned lineNumber = 0; lineNumber < lineContexts.size(); ++lineNumber ) {
1809 lineContexts[lineNumber].crossAxisOffset += lineOffset; 1807 lineContexts[lineNumber].crossAxisOffset += lineOffset;
1810 for (size_t childNumber = 0; childNumber < lineContexts[lineNumber].numb erOfChildren; ++childNumber, child = m_orderIterator.next()) 1808 for (size_t childNumber = 0; childNumber < lineContexts[lineNumber].numb erOfChildren; ++childNumber, child = m_orderIterator.next())
1811 adjustAlignmentForChild(*child, lineOffset); 1809 adjustAlignmentForChild(*child, lineOffset);
1812 1810
1813 if (distribution == ContentDistributionStretch && availableCrossAxisSpac e > 0) 1811 if (distribution == ContentDistributionStretch && availableCrossAxisSpac e > 0)
1814 lineContexts[lineNumber].crossAxisExtent += availableCrossAxisSpace / static_cast<unsigned>(lineContexts.size()); 1812 lineContexts[lineNumber].crossAxisExtent += availableCrossAxisSpace / static_cast<unsigned>(lineContexts.size());
1815 1813
1816 lineOffset += alignContentSpaceBetweenChildren(availableCrossAxisSpace, distribution, lineContexts.size()); 1814 lineOffset += alignContentSpaceBetweenChildren(availableCrossAxisSpace, distribution, lineContexts.size());
1817 } 1815 }
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
1943 DCHECK(child); 1941 DCHECK(child);
1944 LayoutUnit lineCrossAxisExtent = lineContexts[lineNumber].crossAxisE xtent; 1942 LayoutUnit lineCrossAxisExtent = lineContexts[lineNumber].crossAxisE xtent;
1945 LayoutUnit originalOffset = lineContexts[lineNumber].crossAxisOffset - crossAxisStartEdge; 1943 LayoutUnit originalOffset = lineContexts[lineNumber].crossAxisOffset - crossAxisStartEdge;
1946 LayoutUnit newOffset = contentExtent - originalOffset - lineCrossAxi sExtent; 1944 LayoutUnit newOffset = contentExtent - originalOffset - lineCrossAxi sExtent;
1947 adjustAlignmentForChild(*child, newOffset - originalOffset); 1945 adjustAlignmentForChild(*child, newOffset - originalOffset);
1948 } 1946 }
1949 } 1947 }
1950 } 1948 }
1951 1949
1952 } // namespace blink 1950 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-content.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698