Make times easier to read on task list

Make times easier to read on task list

This uses the toLocaleString(), which should use the user's time zone and date preference (e.g. mm/dd/yyyy vs dd/mm/yyyy)

Also fix the vanished checkboxes on the task list filter

BUG=631047
Committed: https://github.com/luci/luci-py/commit/aaedcfee957db268baecd1c7d854cbc58e331dab

[kjlubick, 2016-08-29 13:22:45]

Description was changed from

==========
Make times easier to read on task list

Also fix the vanished checkboxes on the task list filter

BUG=631047
==========

to

==========
Make times easier to read on task list

This uses the toLocaleString(), which should use the user's time zone and date
preference (e.g. mm/dd/yyyy vs dd/mm/yyyy)

Also fix the vanished checkboxes on the task list filter

BUG=631047
==========

[kjlubick, 2016-08-29 13:23:02]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-08-29 13:23:02]

https://screenshot.googleplex.com/Qy35WbjAvvR

[jcgregorio, 2016-08-29 13:28:14]

https://codereview.chromium.org/2289723003/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/tasklist/task-list-data.html (right):

https://codereview.chromium.org/2289723003/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/tasklist/task-list-data.html:254: var
timeZone = str.substring(str.indexOf("("))
The timezone is always going to be the same, extract it just once outside the
.forEach loop.

[kjlubick, 2016-08-29 13:36:49]

https://codereview.chromium.org/2289723003/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/tasklist/task-list-data.html (right):

https://codereview.chromium.org/2289723003/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/tasklist/task-list-data.html:254: var
timeZone = str.substring(str.indexOf("("))
On 2016/08/29 at 13:28:14, jcgregorio wrote:
> The timezone is always going to be the same, extract it just once outside the
.forEach loop.

But what if this code had been running at a particular moment in certain places
in Russia on March 27th, 2016?  
http://www.timeanddate.com/news/time/russia-new-time-zones.html

jk

Done.

[stephana, 2016-08-29 13:41:10]

https://codereview.chromium.org/2289723003/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/tasklist/task-list.html (right):

https://codereview.chromium.org/2289723003/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-list.html:215: function
humanTime(attr) {
There is a lot of abstraction, could you add a comment that describes what
humanTime does?

[kjlubick, 2016-08-29 13:46:33]

https://codereview.chromium.org/2289723003/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/tasklist/task-list.html (right):

https://codereview.chromium.org/2289723003/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-list.html:215: function
humanTime(attr) {
On 2016/08/29 at 13:41:10, stephana wrote:
> There is a lot of abstraction, could you add a comment that describes what
humanTime does?

Done.  This idiom is probably more Go-like, but I think is worth the
deduplication value.

[jcgregorio, 2016-08-29 14:02:45]

lgtm

https://codereview.chromium.org/2289723003/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/tasklist/task-list.html (right):

https://codereview.chromium.org/2289723003/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-list.html:252: // Given a time
attribute like "abandoned_ts", humanTime returns a function
humanTime -> sortableTime

[KevinL, 2016-08-29 14:53:04]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-08-29 14:53:06]

lgtm

[KevinL, 2016-08-29 14:53:08]

The CQ bit was checked by kjlubick@chromium.org

[KevinL, 2016-08-29 14:53:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/2289723003/#ps60001
(title: "Typo")

[commit-bot: I haz the power, 2016-08-29 14:53:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 14:56:32]

Description was changed from

==========
Make times easier to read on task list

This uses the toLocaleString(), which should use the user's time zone and date
preference (e.g. mm/dd/yyyy vs dd/mm/yyyy)

Also fix the vanished checkboxes on the task list filter

BUG=631047
==========

to

==========
Make times easier to read on task list

This uses the toLocaleString(), which should use the user's time zone and date
preference (e.g. mm/dd/yyyy vs dd/mm/yyyy)

Also fix the vanished checkboxes on the task list filter

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/aaedcfee957db268baecd1c7d854cbc58e331dab
==========

[commit-bot: I haz the power, 2016-08-29 14:56:33]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/aaedcfee957db268baecd1c7d854cbc58e331dab