Make times easier to read on task list

appengine/swarming/elements/res/imp/tasklist/task-list-data.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <bot-list-data>
 
@@ skipping 27 matching lines @@
 
   Events:
     None.
 -->
 
 <link rel="import" href="/res/imp/common/common-behavior.html">
 
 <dom-module id="task-list-data">
   <script>
   (function(){
+    var TIMES = ["abandoned_ts", "completed_ts", "created_ts", "modified_ts", "started_ts"];
     Polymer({
       is: 'task-list-data',
 
       behaviors: [
           SwarmingBehaviors.CommonBehavior,
       ],
 
       properties: {
         // inputs
         auth_headers: {
@@ skipping 144 matching lines @@
         pMap["android_devices"].push("0");
         pMap["device_os"].push("none");
         pMap["device_type"].push("none");
         pMap["user"].push("none");
 
         // Custom filter options
         pMap["name"] = [];
         pMap["state"] = ["PENDING", "RUNNING", "PENDING_RUNNING", "COMPLETED",
             "COMPLETED_SUCCESS","COMPLETED_FAILURE", "EXPIRED", "TIMED_OUT",
             "BOT_DIED", "CANCELED", "ALL", "DEDUPED"];
-        pMap["abandoned_ts"] = [];
-        pMap["completed_ts"] = [];
         pMap["costs_usd"] = [];
-        pMap["created_ts"] = [];
         pMap["deduped_from"] = [];
         pMap["duration"] = [];
-        pMap["modified_ts"] = [];
         pMap["server_versions"] = [];
-        pMap["started_ts"] = [];
+        TIMES.forEach(function(t) {
+          pMap[t] = [];
+        });
 
         return pMap;
       },
 
       _request: function() {
         // wait until the user has logged in and the filters have loaded before requesting this to avoid double or even triple requests.
         if (!this.auth_headers || !this.query_params) {
           return;
         }
         this._getJsonAsync("_list", "/_ah/api/swarming/v1/tasks/list",
           "_busy1", this.auth_headers, this.query_params);
       },
 
       _tasks: function() {
         if (!this._list || !this._list.items) {
           return [];
         }
         // Do any preprocessing here
         this._list.items.forEach(function(t) {
           var tagMap = {};
           t.tags.forEach(function(tag) {
             var split = tag.split(":", 1)
             var key = split[0];
             var rest = tag.substring(key.length + 1);
             tagMap[key] = rest;
           });
           t.tagMap = tagMap;
+          TIMES.forEach(function(time) {
+            if (t[time]) {
+              var d = new Date(t[time]);
+              // d.toString looks like "Mon Aug 29 2016 09:03:41 GMT-0400 (EDT)"
+              // we want to extract the time zone part and append it to the
+              // locale time.
+              var str = d.toString();
+              var timeZone = str.substring(str.indexOf("("))

[jcgregorio, 2016/08/29 13:28:14]

The timezone is always going to be the same, extract it just once outside the
.forEach loop.

[kjlubick, 2016/08/29 13:36:49]

But what if this code had been running at a particular moment in certain places
in Russia on March 27th, 2016?  
http://www.timeanddate.com/news/time/russia-new-time-zones.html

jk

Done.

+              var locale = d.toLocaleString();
+              t["human_"+time] = locale + " " + timeZone;
+            }
+          });
         });
         return this._list.items;
       }
     });
   })();
   </script>
 </dom-module>