Also shows detailed diffs on expected diffs.

Also shows detailed diffs on expected diffs.

Since we are going to make whitelisted targets to zero, there is no
reason to avoid to check details on expected diffs.

BUG=314403
Committed: https://crrev.com/29b5fd95fd5f5b1e815cca5ef12c596a4e609620
Cr-Commit-Position: refs/heads/master@{#415109}

[Yoshisato Yanagisawa, 2016-08-29 09:42:41]

yyanagisawa@chromium.org changed reviewers:
+ dpranke@chromium.org, maruel@chromium.org

[M-A Ruel, 2016-08-29 13:56:03]

lgtm

[Dirk Pranke, 2016-08-29 15:51:34]

https://codereview.chromium.org/2289643002/diff/1/tools/determinism/compare_b...
File tools/determinism/compare_build_artifacts.py (right):

https://codereview.chromium.org/2289643002/diff/1/tools/determinism/compare_b...
tools/determinism/compare_build_artifacts.py:632: compare_deps(first_dir,
second_dir, diffs_to_investigate)
Nit: You don't actually need the `if` check on line 628 at all; lines 629-632
will do the
right thing even if run unconditionally, so I would eliminate the branch.

[Dirk Pranke, 2016-08-29 15:51:46]

otherwise lgtm :).

[Yoshisato Yanagisawa, 2016-08-30 01:29:49]

https://codereview.chromium.org/2289643002/diff/1/tools/determinism/compare_b...
File tools/determinism/compare_build_artifacts.py (right):

https://codereview.chromium.org/2289643002/diff/1/tools/determinism/compare_b...
tools/determinism/compare_build_artifacts.py:632: compare_deps(first_dir,
second_dir, diffs_to_investigate)
On 2016/08/29 15:51:34, Dirk Pranke wrote:
> Nit: You don't actually need the `if` check on line 628 at all; lines 629-632
> will do the
> right thing even if run unconditionally, so I would eliminate the branch.

done.
also removed unnecessary set(), and make diffs sorted.

[Yoshisato Yanagisawa, 2016-08-30 01:32:27]

The CQ bit was checked by yyanagisawa@chromium.org

[Yoshisato Yanagisawa, 2016-08-30 01:32:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2289643002/#ps20001
(title: "removed unnecessary condition, etc.")

[commit-bot: I haz the power, 2016-08-30 02:47:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 04:42:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 04:46:20]

Description was changed from

==========
Also shows detailed diffs on expected diffs.

Since we are going to make whitelisted targets to zero, there is no
reason to avoid to check details on expected diffs.

BUG=314403
==========

to

==========
Also shows detailed diffs on expected diffs.

Since we are going to make whitelisted targets to zero, there is no
reason to avoid to check details on expected diffs.

BUG=314403

Committed: https://crrev.com/29b5fd95fd5f5b1e815cca5ef12c596a4e609620
Cr-Commit-Position: refs/heads/master@{#415109}
==========

[commit-bot: I haz the power, 2016-08-30 04:46:21]

Patchset 2 (id:??) landed as
https://crrev.com/29b5fd95fd5f5b1e815cca5ef12c596a4e609620
Cr-Commit-Position: refs/heads/master@{#415109}