tools/determinism/compare_build_artifacts.py - Issue 2289643002: Also shows detailed diffs on expected diffs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/determinism/compare_build_artifacts.py

Issue 2289643002: Also shows detailed diffs on expected diffs. (Closed)

Patch Set: removed unnecessary condition, etc. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/determinism/compare_build_artifacts.py

diff --git a/tools/determinism/compare_build_artifacts.py b/tools/determinism/compare_build_artifacts.py

index 769e73abb1c5f63c07fead8ff85cce3172a3b05a..fb5293e118ad2a44e2baff91c8906117c223b021 100755

--- a/tools/determinism/compare_build_artifacts.py

+++ b/tools/determinism/compare_build_artifacts.py

@@ -625,10 +625,9 @@ def compare_build_artifacts(first_dir, second_dir, target_platform,

for u in unexpected_equals:

print(' %s' % u)

- if unexpected_diffs:

- diffs_to_investigate = set(unexpected_diffs).difference(

- set(missing_files))

- compare_deps(first_dir, second_dir, diffs_to_investigate)

+ all_diffs = expected_diffs + unexpected_diffs

+ diffs_to_investigate = sorted(set(all_diffs).difference(missing_files))

+ compare_deps(first_dir, second_dir, diffs_to_investigate)

return int(bool(unexpected_diffs))

« no previous file with comments | « no previous file | no next file » | no next file with comments »