Remove more unused grit includes in chrome/

Remove more unused grit includes in chrome/

TBR=dbeam@chromium.org

Committed: https://crrev.com/4ae0fad97d052b07ef11426d863b748a02d9736e
Cr-Commit-Position: refs/heads/master@{#415142}

[Lei Zhang, 2016-08-29 20:55:13]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 21:27:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-29 21:43:49]

thestig@chromium.org changed reviewers:
+ tommycli@chromium.org

[Lei Zhang, 2016-08-29 21:49:12]

I wrote an embarrassingly bad Python script to tokenize C++ files with grit/
#includes to look for ID[RS]_ and the match them up to the grit headers. It's
not perfect because:

a) some files do tricky things with grit resources
b) grit only generates resources for the current build config, so the Python
script cannot match up resources that are not used on the current platfirm.

Thus I made the script conservative and this is the approximate output.

[tommycli, 2016-08-29 22:47:54]

LGTM thanks!

I wonder if a conservative version of the bad python script could be a presubmit
to check for unnecessary grits.

[commit-bot: I haz the power, 2016-08-30 03:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:42:19]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-30 04:19:50]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-08-30 04:26:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 04:43:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 04:43:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2016-08-30 04:52:31]

Description was changed from

==========
Remove more unused grit includes in chrome/
==========

to

==========
Remove more unused grit includes in chrome/

TBR=dbeam@chromium.org
==========

[Lei Zhang, 2016-08-30 04:52:31]

thestig@chromium.org changed reviewers:
+ dbeam@chromium.org

[Lei Zhang, 2016-08-30 04:53:17]

TBR dbeam

$ cat chrome/browser/ui/webui/options/OWNERS
# This UI is deprecated. See chrome/browser/ui/webui/options/ instead.

Whaaaa?

[Lei Zhang, 2016-08-30 04:53:23]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-08-30 04:55:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:14:56]

Description was changed from

==========
Remove more unused grit includes in chrome/

TBR=dbeam@chromium.org
==========

to

==========
Remove more unused grit includes in chrome/

TBR=dbeam@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 05:14:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 05:16:48]

Description was changed from

==========
Remove more unused grit includes in chrome/

TBR=dbeam@chromium.org
==========

to

==========
Remove more unused grit includes in chrome/

TBR=dbeam@chromium.org

Committed: https://crrev.com/4ae0fad97d052b07ef11426d863b748a02d9736e
Cr-Commit-Position: refs/heads/master@{#415142}
==========

[commit-bot: I haz the power, 2016-08-30 05:16:50]

Patchset 1 (id:??) landed as
https://crrev.com/4ae0fad97d052b07ef11426d863b748a02d9736e
Cr-Commit-Position: refs/heads/master@{#415142}