Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 228943009: MIPS: Add big-endian support for MIPS. (Closed)

Created:
6 years, 8 months ago by dusmil
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Add big-endian support for MIPS. Important notices: - The snapshot cannot be created for big-endian target in cross-compilation environment on little-endian host using simulator. - In order to have i18n support working on big-endian target, the icudt46b.dat and icudt46b_dat.S files should be generated and upstreamed to ICU repo. - The mjsunit 'nans' test is endian dependent, it is skipped for mips target. - The zlib and Mandreel from Octane 2.0 benchmark are endian dependent due to use of typed arrays. TEST= BUG=

Patch Set 1 #

Total comments: 9

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -188 lines) Patch
M Makefile View 2 chunks +1 line, -5 lines 0 comments Download
M build/toolchain.gypi View 2 chunks +52 lines, -1 line 0 comments Download
M src/conversions-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/globals.h View 4 chunks +8 lines, -4 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +21 lines, -12 lines 0 comments Download
M src/mips/codegen-mips.cc View 12 chunks +221 lines, -112 lines 0 comments Download
M src/mips/constants-mips.h View 2 chunks +21 lines, -0 lines 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 7 chunks +51 lines, -18 lines 0 comments Download
M src/objects.h View 1 3 chunks +14 lines, -7 lines 0 comments Download
M src/runtime.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M test/cctest/test-platform.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 5 chunks +9 lines, -4 lines 0 comments Download
M test/mozilla/mozilla.status View 2 chunks +21 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/run-tests.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dusmil
6 years, 8 months ago (2014-04-14 11:32:04 UTC) #1
Paul Lind
The mips parts LGTM. PTAL at the rest...
6 years, 8 months ago (2014-04-15 00:53:28 UTC) #2
Jakob Kummerow
Looks good, just a few nits and a question. https://codereview.chromium.org/228943009/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/228943009/diff/1/src/objects.h#newcode1959 src/objects.h:1959: ...
6 years, 8 months ago (2014-04-15 08:11:20 UTC) #3
dusmil
https://codereview.chromium.org/228943009/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/228943009/diff/1/src/objects.h#newcode1959 src/objects.h:1959: #if __BYTE_ORDER == __LITTLE_ENDIAN On 2014/04/15 08:11:20, Jakob wrote: ...
6 years, 8 months ago (2014-04-15 15:22:21 UTC) #4
Jakob Kummerow
Platform-independent changes LGTM.
6 years, 8 months ago (2014-04-15 15:29:54 UTC) #5
Paul Lind
6 years, 8 months ago (2014-04-15 16:40:29 UTC) #6
Committed as r20778.

Powered by Google App Engine
This is Rietveld 408576698