Add error information to VerifySignedData().

Add error information to VerifySignedData().

BUG=634443
Committed: https://crrev.com/f4b704e4294b678a474a3053cb7244288255c7fe
Cr-Commit-Position: refs/heads/master@{#416993}

[eroman, 2016-08-30 21:31:44]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 21:32:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-08-30 21:48:02]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 21:48:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-08-30 21:57:39]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2016-08-30 21:57:40]

https://codereview.chromium.org/2289363004/diff/20001/net/cert/internal/verif...
File net/cert/internal/verify_certificate_chain.cc (right):

https://codereview.chromium.org/2289363004/diff/20001/net/cert/internal/verif...
net/cert/internal/verify_certificate_chain.cc:165:
errors->Add(kVerifySignedDataFailed);
I will explore making errors hiearchical in a follow-up to try and address this
deficiency.

For now the errors is a flat list, and there may be some duplicate entries,
which effectively describe the same issue but at varying levels of granularity.

(Need to circle back on that "scoped" context stuff I had added, and see if that
makes sense as a general mechanism, or if errors should just inherently be
hiearchical and have sub-errors within them).

[commit-bot: I haz the power, 2016-08-30 22:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:58:27]

Dry run: This issue passed the CQ dry run.

[mattm, 2016-09-02 23:57:06]

lgtm

[eroman, 2016-09-06 21:23:09]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2016-09-06 21:23:37]

eroman@chromium.org changed reviewers:
+ sheretov@chromium.org

[eroman, 2016-09-06 21:23:38]

+sheretov for Cast approval

[commit-bot: I haz the power, 2016-09-06 21:23:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:46:24]

Dry run: This issue passed the CQ dry run.

[sheretov, 2016-09-07 17:04:42]

On 2016/09/06 21:23:38, eroman wrote:
> +sheretov for Cast approval

lgtm.

I like the approach of passing an error sink to the verify() function. Something
we should consider adding to cast_certificate::VerifyDeviceCert().

[eroman, 2016-09-07 17:54:00]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-09-07 17:54:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2289363004/#ps40001
(title: "rebase onto origin/master")

[commit-bot: I haz the power, 2016-09-07 17:54:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:58:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-07 18:02:24]

Description was changed from

==========
Add error information to VerifySignedData().

BUG=634443
==========

to

==========
Add error information to VerifySignedData().

BUG=634443

Committed: https://crrev.com/f4b704e4294b678a474a3053cb7244288255c7fe
Cr-Commit-Position: refs/heads/master@{#416993}
==========

[commit-bot: I haz the power, 2016-09-07 18:02:26]

Patchset 3 (id:??) landed as
https://crrev.com/f4b704e4294b678a474a3053cb7244288255c7fe
Cr-Commit-Position: refs/heads/master@{#416993}