Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: net/cert/internal/verify_certificate_chain.cc

Issue 2289363004: Add error information to VerifySignedData(). (Closed)
Patch Set: rebase onto origin/master Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/verify_certificate_chain.h ('k') | net/cert/internal/verify_signed_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_certificate_chain.cc
diff --git a/net/cert/internal/verify_certificate_chain.cc b/net/cert/internal/verify_certificate_chain.cc
index 956c1736cbadcbb45f222e177ab1927a253e7515..df0c11e72d1ddb2fc1218cf73c8b886869e21405 100644
--- a/net/cert/internal/verify_certificate_chain.cc
+++ b/net/cert/internal/verify_certificate_chain.cc
@@ -160,9 +160,9 @@ WARN_UNUSED_RESULT bool BasicCertificateProcessing(
}
if (!VerifySignedData(cert.signature_algorithm(), cert.tbs_certificate_tlv(),
- cert.signature_value(), working_spki,
- signature_policy)) {
- errors->Add(kSignatureVerificationFailed);
+ cert.signature_value(), working_spki, signature_policy,
+ errors)) {
+ errors->Add(kVerifySignedDataFailed);
return false;
}
@@ -584,8 +584,7 @@ DEFINE_CERT_ERROR_TYPE(kNotPermittedByNameConstraints,
"Not permitted by name constraints");
DEFINE_CERT_ERROR_TYPE(kSubjectDoesNotMatchIssuer,
"subject does not match issuer");
-DEFINE_CERT_ERROR_TYPE(kSignatureVerificationFailed,
- "Signature verification failed");
+DEFINE_CERT_ERROR_TYPE(kVerifySignedDataFailed, "VerifySignedData failed");
DEFINE_CERT_ERROR_TYPE(kValidityFailedNotAfter, "Time is after notAfter");
DEFINE_CERT_ERROR_TYPE(kValidityFailedNotBefore, "Time is before notBefore");
DEFINE_CERT_ERROR_TYPE(kSignatureAlgorithmsDifferentEncoding,
« no previous file with comments | « net/cert/internal/verify_certificate_chain.h ('k') | net/cert/internal/verify_signed_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698