Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2289353002: [layoutng] Add methods to compute border and padding (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Add methods to compute border and padding R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/e7fe98f3266e524d133c285ccc944f4e48d9c9e4 Cr-Commit-Position: refs/heads/master@{#415468}

Patch Set 1 #

Total comments: 4

Patch Set 2 : better enum name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 1 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 4 chunks +44 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
cbiesinger
4 years, 3 months ago (2016-08-30 20:12:03 UTC) #1
Gleb Lanbin
lgtm https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc (right): https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc#newcode217 third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc:217: style_->setPaddingRight(Length(52, Fixed)); .nit it's better to use constants.
4 years, 3 months ago (2016-08-30 20:18:35 UTC) #4
cbiesinger
https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc (right): https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc#newcode217 third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc:217: style_->setPaddingRight(Length(52, Fixed)); On 2016/08/30 20:18:34, glebl wrote: > .nit ...
4 years, 3 months ago (2016-08-30 20:19:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289353002/1
4 years, 3 months ago (2016-08-30 20:22:44 UTC) #8
ikilpatrick
lgtm https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right): https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc#newcode154 third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:154: constraintSpace, style.paddingBefore(), LengthResolveType::MarginSize); Is LengthResolveType::MarginSize better named something ...
4 years, 3 months ago (2016-08-30 20:30:44 UTC) #9
cbiesinger
https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right): https://codereview.chromium.org/2289353002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc#newcode154 third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:154: constraintSpace, style.paddingBefore(), LengthResolveType::MarginSize); On 2016/08/30 20:30:44, ikilpatrick wrote: > ...
4 years, 3 months ago (2016-08-30 20:32:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289353002/20001
4 years, 3 months ago (2016-08-30 20:35:50 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 22:42:01 UTC) #15
eae
Nice!
4 years, 3 months ago (2016-08-30 22:42:17 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:44:49 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e7fe98f3266e524d133c285ccc944f4e48d9c9e4
Cr-Commit-Position: refs/heads/master@{#415468}

Powered by Google App Engine
This is Rietveld 408576698