[layoutng] Add methods to compute border and padding

third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_length_utils.h"
 
 #include "core/layout/ng/ng_constraint_space.h"
 #include "core/layout/ng/ng_derived_constraint_space.h"
 #include "core/layout/ng/ng_margin_strut.h"
 #include "core/style/ComputedStyle.h"
@@ skipping 175 matching lines @@
   NGConstraintSpace* constraintSpace(ConstructConstraintSpace(200, 300));
 
   NGBoxStrut margins = computeMargins(*constraintSpace, *style_);
 
   EXPECT_EQ(LayoutUnit(20), margins.block_start);
   EXPECT_EQ(LayoutUnit(52), margins.inline_end);
   EXPECT_EQ(LayoutUnit(), margins.block_end);
   EXPECT_EQ(LayoutUnit(22), margins.inline_start);
 }
 
+TEST_F(NGLengthUtilsTest, testBorders) {
+  style_->setBorderTopWidth(1);
+  style_->setBorderRightWidth(2);
+  style_->setBorderBottomWidth(3);
+  style_->setBorderLeftWidth(4);
+  style_->setBorderTopStyle(BorderStyleSolid);
+  style_->setBorderRightStyle(BorderStyleSolid);
+  style_->setBorderBottomStyle(BorderStyleSolid);
+  style_->setBorderLeftStyle(BorderStyleSolid);
+  style_->setWritingMode(LeftToRightWritingMode);
+
+  NGBoxStrut borders = computeBorders(*style_);
+
+  EXPECT_EQ(LayoutUnit(4), borders.block_start);
+  EXPECT_EQ(LayoutUnit(3), borders.inline_end);
+  EXPECT_EQ(LayoutUnit(2), borders.block_end);
+  EXPECT_EQ(LayoutUnit(1), borders.inline_start);
+}
+
+TEST_F(NGLengthUtilsTest, testPadding) {
+  style_->setPaddingTop(Length(10, Percent));
+  style_->setPaddingRight(Length(52, Fixed));

[Gleb Lanbin, 2016/08/30 20:18:34]

.nit it's better to use constants.

[cbiesinger, 2016/08/30 20:19:54]

To use the same constant for the setting and testing? But that doesn't work for
the percentages... not sure it's worth it for the one fixed value.

+  style_->setPaddingBottom(Length(Auto));
+  style_->setPaddingLeft(Length(11, Percent));
+  style_->setWritingMode(RightToLeftWritingMode);
+
+  NGConstraintSpace* constraintSpace(ConstructConstraintSpace(200, 300));
+
+  NGBoxStrut padding = computePadding(*constraintSpace, *style_);
+
+  EXPECT_EQ(LayoutUnit(52), padding.block_start);
+  EXPECT_EQ(LayoutUnit(), padding.inline_end);
+  EXPECT_EQ(LayoutUnit(22), padding.block_end);
+  EXPECT_EQ(LayoutUnit(20), padding.inline_start);
+}
+
 }  // namespace
 }  // namespace blink