Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2289333002: ThreadWatcher: fix use-after-free bug. (Closed)

Created:
4 years, 3 months ago by Joshua LeVasseur
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ThreadWatcher: fix use-after-free bug. Take copies, not referrences, when passing data to another thread in the WatchingParams. BUG=none TEST=unit tests Committed: https://crrev.com/127eb67f30ae88c5e0bb3e81ba0a391b4d3beec3 Cr-Commit-Position: refs/heads/master@{#415717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/metrics/thread_watcher.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Joshua LeVasseur
This is in preparation for turning ThreadWatcher into a component.
4 years, 3 months ago (2016-08-30 21:22:04 UTC) #6
ramant (doing other things)
lgtm
4 years, 3 months ago (2016-08-30 21:39:55 UTC) #7
wzhong
lgtm
4 years, 3 months ago (2016-08-30 22:58:29 UTC) #10
Ilya Sherman
LGTM, thanks.
4 years, 3 months ago (2016-08-30 23:45:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289333002/1
4 years, 3 months ago (2016-08-31 19:09:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 19:15:36 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:19:24 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/127eb67f30ae88c5e0bb3e81ba0a391b4d3beec3
Cr-Commit-Position: refs/heads/master@{#415717}

Powered by Google App Engine
This is Rietveld 408576698