Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/metrics/thread_watcher.h

Issue 2289333002: ThreadWatcher: fix use-after-free bug. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/thread_watcher.h
diff --git a/chrome/browser/metrics/thread_watcher.h b/chrome/browser/metrics/thread_watcher.h
index 6bf8d15cd1fccf0abf0abe431b6906861587f506..aa2046f30a23628d984633b9f48918730d4752fd 100644
--- a/chrome/browser/metrics/thread_watcher.h
+++ b/chrome/browser/metrics/thread_watcher.h
@@ -78,10 +78,10 @@ class ThreadWatcher {
// base::Bind supports methods with up to 6 parameters. WatchingParams is used
// as a workaround that limitation for invoking ThreadWatcher::StartWatching.
struct WatchingParams {
- const content::BrowserThread::ID& thread_id;
- const std::string& thread_name;
- const base::TimeDelta& sleep_time;
- const base::TimeDelta& unresponsive_time;
+ content::BrowserThread::ID thread_id;
+ std::string thread_name;
+ base::TimeDelta sleep_time;
+ base::TimeDelta unresponsive_time;
uint32_t unresponsive_threshold;
bool crash_on_hang;
uint32_t live_threads_threshold;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698