Issue 22893050: Get rid of duplicated CPU::DebugBreak() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22893050: Get rid of duplicated CPU::DebugBreak() method. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne, Michael Starzinger, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Get rid of duplicated CPU::DebugBreak() method. We already have OS::DebugBreak(), which does the right thing. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16293

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -47 lines)			Patch
M	src/arm/cpu-arm.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/cpu.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ia32/cpu-ia32.cc	View	1 chunk	+0 lines, -14 lines	2 comments	Download
M	src/mips/cpu-mips.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/cpu-x64.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with one comment. https://codereview.chromium.org/22893050/diff/1/src/ia32/cpu-ia32.cc File src/ia32/cpu-ia32.cc (left): https://codereview.chromium.org/22893050/diff/1/src/ia32/cpu-ia32.cc#oldcode80 src/ia32/cpu-ia32.cc:80: // __asm { int 3 ...

7 years, 4 months ago (2013-08-23 11:43:43 UTC) #4

Benedikt Meurer

7 years, 4 months ago (2013-08-23 11:50:43 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/22893050/diff/1/src/ia32/cpu-ia32.cc
File src/ia32/cpu-ia32.cc (left):

https://codereview.chromium.org/22893050/diff/1/src/ia32/cpu-ia32.cc#oldcode80
src/ia32/cpu-ia32.cc:80: // __asm { int 3 }
On 2013/08/23 11:43:43, Michael Starzinger wrote:
> We could preserve these three lines of comments in in the platform-win32.cc
> file.

Will be addressed in separate CL.

Expand Messages | Collapse Messages