Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2289293002: clean up use of register storage class (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

clean up use of register storage class This fixes this warning-as-error, so we don't have to stifle it any more: error: 'register' storage class specifier is deprecated and incompatible with C++1z [-Werror,-Wdeprecated-register] Tested by building for mipsel via GN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289293002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/b6064ef5b822ebc14d62170bd4ffa2f7c9bfbe4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 8 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 3 months ago (2016-08-30 18:13:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289293002/1
4 years, 3 months ago (2016-08-30 18:13:48 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-30 18:13:50 UTC) #7
jcgregorio
lgtm
4 years, 3 months ago (2016-08-30 18:16:16 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 18:49:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b6064ef5b822ebc14d62170bd4ffa2f7c9bfbe4d

Powered by Google App Engine
This is Rietveld 408576698