Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2289263003: Revert of Add support for method selection in the Payment Request UI on iOS. (Closed)

Created:
4 years, 3 months ago by mdjones
Modified:
4 years, 3 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for method selection in the Payment Request UI on iOS. (patchset #4 id:80001 of https://codereview.chromium.org/2285523002/ ) Reason for revert: Breaking testMultilineStreetAddress on KitKat Tablet Tester Original issue's description: > Add support for method selection in the Payment Request UI on iOS. > > This includes: > - Moving the mapping between autofill credit card types and types > defined in the spec to components/autofill. > - Adding the basic credit card response type from the spec. > > BUG=602666 > > Committed: https://crrev.com/c3d5660f6d497ea5dffc885f198cefdc7aabad83 > Cr-Commit-Position: refs/heads/master@{#415351} TBR=marq@chromium.org,eugenebut@chromium.org,estade@chromium.org,jdonnelly@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602666 Committed: https://crrev.com/741a16eae56e4feb2dbbf2a50b5db07a3810a2ef Cr-Commit-Position: refs/heads/master@{#415436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -320 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 5 chunks +50 lines, -10 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.h View 3 chunks +0 lines, -18 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M components/resources/autofill_scaled_resources.grdp View 1 chunk +13 lines, -16 lines 0 comments Download
M ios/web/payments/payment_request.cc View 5 chunks +5 lines, -106 lines 0 comments Download
M ios/web/payments/payment_request_unittest.cc View 3 chunks +15 lines, -87 lines 0 comments Download
M ios/web/public/payments/payment_request.h View 3 chunks +7 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mdjones
Created Revert of Add support for method selection in the Payment Request UI on iOS.
4 years, 3 months ago (2016-08-30 21:38:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289263003/1
4 years, 3 months ago (2016-08-30 21:38:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:39:54 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:43:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/741a16eae56e4feb2dbbf2a50b5db07a3810a2ef
Cr-Commit-Position: refs/heads/master@{#415436}

Powered by Google App Engine
This is Rietveld 408576698