Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2289183005: [WeakMemoryCache] Cleanup Field-Trial code (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
Reviewers:
kinuko, Nate Chapin
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WeakMemoryCache] Cleanup Field-Trial code [1] was partially reverted by [2]. This CL reverts the rest of [1] to remove Field-Trial-related code. [1] https://codereview.chromium.org/1915113005 [2] https://codereview.chromium.org/2110823003 BUG=603462 Committed: https://crrev.com/7356fd5e3a42bc48f010b54f9013d1494f662079 Cr-Commit-Position: refs/heads/master@{#416842}

Patch Set 1 #

Patch Set 2 : rebase error fix #

Total comments: 2

Patch Set 3 : g #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/content_features.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 2 3 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
hiroshige
PTAL isherman@ as tools/metrics/ OWNER, kiunko@ as a content/, platform/, public/ OWNER, japhet@ as a ...
4 years, 3 months ago (2016-09-01 09:16:37 UTC) #3
Ilya Sherman
https://codereview.chromium.org/2289183005/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2289183005/diff/20001/tools/metrics/histograms/histograms.xml#oldcode85455 tools/metrics/histograms/histograms.xml:85455: - <int value="1612446645" label="enable-weak-memorycache"/> Please keep this value in ...
4 years, 3 months ago (2016-09-01 19:16:38 UTC) #4
kinuko
On 2016/09/01 09:16:37, hiroshige wrote: > PTAL > isherman@ as tools/metrics/ OWNER, > kiunko@ as ...
4 years, 3 months ago (2016-09-02 05:24:40 UTC) #5
hiroshige
https://codereview.chromium.org/2289183005/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2289183005/diff/20001/tools/metrics/histograms/histograms.xml#oldcode85455 tools/metrics/histograms/histograms.xml:85455: - <int value="1612446645" label="enable-weak-memorycache"/> On 2016/09/01 19:16:38, Ilya Sherman ...
4 years, 3 months ago (2016-09-02 09:34:04 UTC) #6
Ilya Sherman
Thanks! With the histograms.xml change reverted, you no longer need my review; recusing myself.
4 years, 3 months ago (2016-09-02 17:30:13 UTC) #8
Nate Chapin
lgtm
4 years, 3 months ago (2016-09-06 20:42:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289183005/40001
4 years, 3 months ago (2016-09-07 01:08:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/264056)
4 years, 3 months ago (2016-09-07 01:11:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289183005/60001
4 years, 3 months ago (2016-09-07 02:04:02 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-07 04:07:14 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 04:09:10 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7356fd5e3a42bc48f010b54f9013d1494f662079
Cr-Commit-Position: refs/heads/master@{#416842}

Powered by Google App Engine
This is Rietveld 408576698