Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2110823003: [WeakMemoryCache] Partial revert of Field-Trial: Make Reference from MemoryCache to Resource weak (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WeakMemoryCache] Revert Field-Trial: Make Reference from MemoryCache to Resource weak This is partial revert of https://codereview.chromium.org/1915113005. The modifications in MemoryCache are reverted before going to beta because it might be not so stable, while other field-trial related changes are kept because I'm planning further experiment in the next milestone. BUG=603462 Committed: https://crrev.com/117933b658ec04474d2862a4fae1e5e52fb15e0b Cr-Commit-Position: refs/heads/master@{#403148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -48 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 1 chunk +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 12 chunks +7 lines, -41 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110823003/1
4 years, 5 months ago (2016-06-30 05:27:33 UTC) #2
hiroshige
PTAL.
4 years, 5 months ago (2016-06-30 05:38:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 06:38:51 UTC) #8
kinuko
I assume we keep the weakMemoryCache flag for now in order to do further iteration ...
4 years, 5 months ago (2016-06-30 06:52:06 UTC) #9
hiroshige
On 2016/06/30 06:52:06, kinuko wrote: > I assume we keep the weakMemoryCache flag for now ...
4 years, 5 months ago (2016-06-30 11:23:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110823003/1
4 years, 5 months ago (2016-06-30 11:24:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 11:56:49 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 11:56:56 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 11:59:54 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/117933b658ec04474d2862a4fae1e5e52fb15e0b
Cr-Commit-Position: refs/heads/master@{#403148}

Powered by Google App Engine
This is Rietveld 408576698