Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/browser_sync/browser/profile_sync_service.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase, address comments, remove TestMessageLoop. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/browser/profile_sync_service.cc
diff --git a/components/browser_sync/browser/profile_sync_service.cc b/components/browser_sync/browser/profile_sync_service.cc
index 1c9aac928fb0966c440626dd5a23679dfeb8bfb3..180cf4271567ba16ab48fa89b3236efd6d1b3cd6 100644
--- a/components/browser_sync/browser/profile_sync_service.cc
+++ b/components/browser_sync/browser/profile_sync_service.cc
@@ -424,9 +424,10 @@ void ProfileSyncService::UnregisterAuthNotifications() {
}
void ProfileSyncService::RegisterDataTypeController(
- sync_driver::DataTypeController* data_type_controller) {
+ std::unique_ptr<sync_driver::DataTypeController> data_type_controller) {
DCHECK_EQ(data_type_controllers_.count(data_type_controller->type()), 0U);
skym 2016/09/02 22:45:28 Ugh, count(...). What do you think of find?
maxbogue 2016/09/03 00:14:51 Didn't compile for some reason... "error: no match
- data_type_controllers_[data_type_controller->type()] = data_type_controller;
+ data_type_controllers_[data_type_controller->type()] =
+ std::move(data_type_controller);
}
bool ProfileSyncService::IsDataTypeControllerRunning(

Powered by Google App Engine
This is Rietveld 408576698