[Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h

Index: chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
diff --git a/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h b/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
index d8e7050fc76c0b0c645c7f3a23bdbadc66b6759b..9ed16113fc953ee3b6f32b11c87b2a86e2c963a0 100644
--- a/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
+++ b/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
@@ -20,17 +20,16 @@ class Profile;
 class SupervisedUserSyncDataTypeController
     : public sync_driver::UIDataTypeController {
  public:
+  // |dump_stack| is called when an unrecoverable error occurs.

[skym, 2016/09/02 22:45:28]

Is this technically correct? I thought
DataTypeErrorHandlerImpl::CreateAndUploadError(...) wasn't always called when
unrecoverable, didn't always get back to sync.

[maxbogue, 2016/09/03 00:14:50]

I think the error always gets back to sync one way or another. It's close enough
for now; we should revisit the error handling stuff one day anyways.

   SupervisedUserSyncDataTypeController(syncer::ModelType type,
-                                       const base::Closure& error_callback,
+                                       const base::Closure& dump_stack,
                                        sync_driver::SyncClient* sync_client,
                                        Profile* profile);
+  ~SupervisedUserSyncDataTypeController() override;
 
   bool ReadyForStart() const override;
 
  private:
-  // DataTypeController is RefCounted.
-  ~SupervisedUserSyncDataTypeController() override;
-
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(SupervisedUserSyncDataTypeController);