[Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc

Index: chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
diff --git a/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc b/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
index e8a8c5211514cf8746ce2222e3564f97568b048f..eac4d6dbbcbbfdbda9a23adb4b17b837f550c708 100644
--- a/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
+++ b/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
@@ -5,19 +5,13 @@
 #include "chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h"
 
 #include "chrome/browser/profiles/profile.h"
-#include "content/public/browser/browser_thread.h"

[skym, 2016/09/02 22:45:28]

Now that this class doesn't depend on content anymore, should it be moved closer
to its syncable service like some of the other controllers?

[maxbogue, 2016/09/03 00:14:50]

Looks like its service is in //chrome/browser/supervised_user/legacy/ so I think
leaving it is fine.

 
 SupervisedUserSyncDataTypeController::SupervisedUserSyncDataTypeController(
     syncer::ModelType type,
-    const base::Closure& error_callback,
+    const base::Closure& dump_stack,
     sync_driver::SyncClient* sync_client,
     Profile* profile)
-    : sync_driver::UIDataTypeController(
-          content::BrowserThread::GetTaskRunnerForThread(
-              content::BrowserThread::UI),
-          error_callback,
-          type,
-          sync_client),
+    : sync_driver::UIDataTypeController(type, dump_stack, sync_client),
       profile_(profile) {
   DCHECK(type == syncer::SUPERVISED_USERS ||
          type == syncer::SUPERVISED_USER_SETTINGS ||
@@ -28,6 +22,7 @@ SupervisedUserSyncDataTypeController::SupervisedUserSyncDataTypeController(
 SupervisedUserSyncDataTypeController::~SupervisedUserSyncDataTypeController() {}
 
 bool SupervisedUserSyncDataTypeController::ReadyForStart() const {
+  DCHECK(CalledOnValidThread());
   switch (type()) {
     case syncer::SUPERVISED_USERS:
       return !profile_->IsSupervised();