Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: Source/core/css/BasicShapeFunctions.cpp

Issue 228903002: [CSS Shapes] inset complex calc() args vanish in serialized computed style (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/shapes/parsing/parsing-test-utils.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/BasicShapeFunctions.cpp
diff --git a/Source/core/css/BasicShapeFunctions.cpp b/Source/core/css/BasicShapeFunctions.cpp
index 3df34af0873c8b60eab05f25fc077d0a3bd12a2b..97c0fd0ef28782cae10a5f6f1dbe2ed838647f68 100644
--- a/Source/core/css/BasicShapeFunctions.cpp
+++ b/Source/core/css/BasicShapeFunctions.cpp
@@ -108,10 +108,10 @@ PassRefPtrWillBeRawPtr<CSSValue> valueForBasicShape(const RenderStyle& style, co
const BasicShapeInset* inset = static_cast<const BasicShapeInset*>(basicShape);
RefPtrWillBeRawPtr<CSSBasicShapeInset> insetValue = CSSBasicShapeInset::create();
- insetValue->setTop(CSSPrimitiveValue::create(inset->top()));
- insetValue->setRight(CSSPrimitiveValue::create(inset->right()));
- insetValue->setBottom(CSSPrimitiveValue::create(inset->bottom()));
- insetValue->setLeft(CSSPrimitiveValue::create(inset->left()));
+ insetValue->setTop(pool.createValue(inset->top(), style));
+ insetValue->setRight(pool.createValue(inset->right(), style));
+ insetValue->setBottom(pool.createValue(inset->bottom(), style));
+ insetValue->setLeft(pool.createValue(inset->left(), style));
insetValue->setTopLeftRadius(CSSPrimitiveValue::create(inset->topLeftRadius()));
insetValue->setTopRightRadius(CSSPrimitiveValue::create(inset->topRightRadius()));
« no previous file with comments | « LayoutTests/fast/shapes/parsing/parsing-test-utils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698