Issue 2289013002: Merge: MD Downloads: fix search spinner when terms are the same

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2289013002: Merge: MD Downloads: fix search spinner when terms are the same (Closed)

Created:
4 years, 3 months ago by Dan Beam

Modified:
4 years, 3 months ago

Reviewers:
tsergeant

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Merge: MD Downloads: fix search spinner when terms are the same R=tsergeant@chromium.org BUG=640893 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2284463002 Cr-Commit-Position: refs/heads/master@{#414643} (cherry picked from commit ad86c212a9e1b3d608c99a3d903da1cbfc1e74df) Committed: https://chromium.googlesource.com/chromium/src/+/3fe68ce49e15112e888c77e0ef0b27b026a7f2b3

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -18 lines)			Patch
M	chrome/browser/resources/md_downloads/action_service.js	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/action_service_unittest.gtestjs	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/crisper.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/toolbar.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/toolbar.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/vulcanized.html	View	1 chunk	+4 lines, -11 lines	0 comments	Download
M	chrome/test/data/webui/md_downloads/toolbar_tests.js	View	2 chunks	+25 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Dan Beam

4 years, 3 months ago (2016-08-30 00:53:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3fe68ce49e15112e888c77e0ef0b27b026a7f2b3.