Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2284463002: MD Downloads: fix search spinner when terms are the same (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix search spinner when terms are the same R=tsergeant@chromium.org BUG=640893 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ad86c212a9e1b3d608c99a3d903da1cbfc1e74df Cr-Commit-Position: refs/heads/master@{#414643}

Patch Set 1 : +tests #

Total comments: 2

Patch Set 2 : tsergeant@ review / test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -18 lines) Patch
M chrome/browser/resources/md_downloads/action_service.js View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/action_service_unittest.gtestjs View 1 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +4 lines, -11 lines 0 comments Download
M chrome/test/data/webui/md_downloads/toolbar_tests.js View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Dan Beam
4 years, 3 months ago (2016-08-25 20:09:40 UTC) #2
tsergeant
lgtm % fixing the test https://codereview.chromium.org/2284463002/diff/40001/chrome/browser/resources/md_downloads/action_service_unittest.gtestjs File chrome/browser/resources/md_downloads/action_service_unittest.gtestjs (right): https://codereview.chromium.org/2284463002/diff/40001/chrome/browser/resources/md_downloads/action_service_unittest.gtestjs#newcode41 chrome/browser/resources/md_downloads/action_service_unittest.gtestjs:41: TEST_F('ActionServiceUnitTest', 'searchWithSimilarTerms', function() { ...
4 years, 3 months ago (2016-08-25 23:22:22 UTC) #9
Dan Beam
https://codereview.chromium.org/2284463002/diff/40001/chrome/browser/resources/md_downloads/action_service_unittest.gtestjs File chrome/browser/resources/md_downloads/action_service_unittest.gtestjs (right): https://codereview.chromium.org/2284463002/diff/40001/chrome/browser/resources/md_downloads/action_service_unittest.gtestjs#newcode41 chrome/browser/resources/md_downloads/action_service_unittest.gtestjs:41: TEST_F('ActionServiceUnitTest', 'searchWithSimilarTerms', function() { On 2016/08/25 23:22:22, tsergeant wrote: ...
4 years, 3 months ago (2016-08-25 23:49:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284463002/60001
4 years, 3 months ago (2016-08-25 23:50:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/269208)
4 years, 3 months ago (2016-08-26 00:50:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284463002/60001
4 years, 3 months ago (2016-08-26 00:56:04 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 3 months ago (2016-08-26 03:25:29 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 03:29:22 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad86c212a9e1b3d608c99a3d903da1cbfc1e74df
Cr-Commit-Position: refs/heads/master@{#414643}

Powered by Google App Engine
This is Rietveld 408576698