Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2289003002:
CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor (Closed)
|
Created:
4 years, 3 months ago by horo Modified:
4 years, 3 months ago Reviewers:
falken CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCHECK instance_info_.empty() in ServiceWorkerProcessManager destructor
To verify that ServiceWorkerProcessManager doesn't prevent render
process hosts from shutting down.
BUG=639193, 636377
Committed: https://crrev.com/e60baa3aa1365c8c0002631ffe95c790e6a0ab1e
Cr-Commit-Position: refs/heads/master@{#415193}
Patch Set 1 #Patch Set 2 : add comments #Messages
Total messages: 20 (13 generated)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Description was changed from ========== CKECK instance_info_.empty() in ServiceWorkerProcessManager destructor BUG=639193 ========== to ========== CKECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193 ==========
horo@chromium.org changed reviewers: + falken@chromium.org
falken@ Could you please review this?
lgtm
s/CKECK/CHECK in the CL description
Description was changed from ========== CKECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193 ========== to ========== CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193 ==========
On 2016/08/30 01:12:53, falken wrote: > s/CKECK/CHECK in the CL description done
Description was changed from ========== CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193 ========== to ========== CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193,636377 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by horo@chromium.org
The CQ bit was checked by horo@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193,636377 ========== to ========== CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193,636377 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193,636377 ========== to ========== CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor To verify that ServiceWorkerProcessManager doesn't prevent render process hosts from shutting down. BUG=639193,636377 Committed: https://crrev.com/e60baa3aa1365c8c0002631ffe95c790e6a0ab1e Cr-Commit-Position: refs/heads/master@{#415193} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e60baa3aa1365c8c0002631ffe95c790e6a0ab1e Cr-Commit-Position: refs/heads/master@{#415193} |
