Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/browser/service_worker/service_worker_process_manager.cc

Issue 2289003002: CHECK instance_info_.empty() in ServiceWorkerProcessManager destructor (Closed)
Patch Set: add comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_process_manager.cc
diff --git a/content/browser/service_worker/service_worker_process_manager.cc b/content/browser/service_worker/service_worker_process_manager.cc
index 836297b165694717893df9859eac134fdcbfd5aa..b6cdeb556c777b08f0af06dd85c18c2e1437777a 100644
--- a/content/browser/service_worker/service_worker_process_manager.cc
+++ b/content/browser/service_worker/service_worker_process_manager.cc
@@ -64,7 +64,10 @@ ServiceWorkerProcessManager::~ServiceWorkerProcessManager() {
DCHECK(IsShutdown())
<< "Call Shutdown() before destroying |this|, so that racing method "
<< "invocations don't use a destroyed BrowserContext.";
- DCHECK(instance_info_.empty());
+ // TODO(horo): Remove after collecting crash data.
+ // Temporary checks to verify that ServiceWorkerProcessManager doesn't prevent
+ // render process hosts from shutting down: crbug.com/639193
+ CHECK(instance_info_.empty());
}
void ServiceWorkerProcessManager::Shutdown() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698