Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2288983002: Move error checking from scope creation to error reporter (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move error checking from scope creation to error reporter R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ca206a29e72df0e4e0e8dde0bcdba6c4fe896c14

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -23 lines) Patch
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +9 lines, -7 lines 2 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 8 chunks +205 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This is to enable some necessary changes to the way scopes are created.
4 years, 3 months ago (2016-08-29 22:26:42 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2288983002/diff/1/pkg/analyzer/lib/src/dart/resolver/scope.dart File pkg/analyzer/lib/src/dart/resolver/scope.dart (right): https://codereview.chromium.org/2288983002/diff/1/pkg/analyzer/lib/src/dart/resolver/scope.dart#newcode1112 pkg/analyzer/lib/src/dart/resolver/scope.dart:1112: // if (_definedNames != null && _definedNames.containsKey(name)) { ...
4 years, 3 months ago (2016-08-30 01:34:44 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2288983002/diff/1/pkg/analyzer/lib/src/dart/resolver/scope.dart File pkg/analyzer/lib/src/dart/resolver/scope.dart (right): https://codereview.chromium.org/2288983002/diff/1/pkg/analyzer/lib/src/dart/resolver/scope.dart#newcode1112 pkg/analyzer/lib/src/dart/resolver/scope.dart:1112: // if (_definedNames != null && _definedNames.containsKey(name)) { No, ...
4 years, 3 months ago (2016-08-30 13:13:45 UTC) #4
Brian Wilkerson
4 years, 3 months ago (2016-08-30 13:13:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ca206a29e72df0e4e0e8dde0bcdba6c4fe896c14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698