Move error checking from scope creation to error reporter

pkg/analyzer/lib/src/dart/resolver/scope.dart

Index: pkg/analyzer/lib/src/dart/resolver/scope.dart
diff --git a/pkg/analyzer/lib/src/dart/resolver/scope.dart b/pkg/analyzer/lib/src/dart/resolver/scope.dart
index ba5b275cbb1395f58ec9433ece3449d9870c7cfa..47a88f99cbcd5b218f8028a08f285d5992b68035 100644
--- a/pkg/analyzer/lib/src/dart/resolver/scope.dart
+++ b/pkg/analyzer/lib/src/dart/resolver/scope.dart
@@ -1107,13 +1107,15 @@ abstract class Scope {
   void define(Element element) {
     String name = _getName(element);
     if (name != null && !name.isEmpty) {
-      if (_definedNames != null && _definedNames.containsKey(name)) {
-        errorListener
-            .onError(getErrorForDuplicate(_definedNames[name], element));
-      } else {
-        _definedNames ??= new HashMap<String, Element>();
-        _definedNames[name] = element;
-      }
+      _definedNames ??= new HashMap<String, Element>();
+      _definedNames.putIfAbsent(name, () => element);
+//      if (_definedNames != null && _definedNames.containsKey(name)) {

[scheglov, 2016/08/30 01:34:44]

Are we going to need this code later?

[Brian Wilkerson, 2016/08/30 13:13:44]

No, I intended to remove it. Done.

+//        errorListener
+//            .onError(getErrorForDuplicate(_definedNames[name], element));
+//      } else {
+//        _definedNames ??= new HashMap<String, Element>();
+//        _definedNames[name] = element;
+//      }
     }
   }