Merge TaskSynchronizer into WaitableEvent.

Merge TaskSynchronizer into WaitableEvent.


BUG=

[esprehn, 2016-08-29 22:03:07]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 23:01:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-29 23:03:45]

[0829/154859:ERROR:kill_posix.cc(84)] Unable to terminate process group 16711:
No such process
[ RUN      ] WorkerTest.WorkerTlsClientAuth
ASSERTION FAILED: !m_state->isAtSafePoint()
../../third_party/WebKit/Source/platform/heap/SafePoint.h(21) :
blink::SafePointScope::SafePointScope(BlinkGC::StackState, blink::ThreadState *)
1   0x3a8626f
2   0x3a858da
3   0x3b2439e
4   0x3b1ccdd
5   0x32d55b0
6   0xc738ec
7   0xd04e3f
8   0xd03c95
9   0xd0399e
10  0x3f31225063a7
Received signal 11 SEGV_MAPERR 0000fbadbeef
#0 0x000001f92127 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f7b3cbdbcb0 <unknown>
#2 0x00000493bd61
[16711:16738:0829/154829:1203521583:ERROR:openssl_ssl_util.cc(168)] OpenSSL
SYSCALL error, earliest error code in error queue: 0, errno: 0
[16711:16738:0829/154829:1203521614:ERROR:ssl_server_socket_impl.cc(733)]
handshake failed; returned 0, SSL error code 5, net_error -2
blink::WaitableEvent::wait()
#3 0x000003a8626f blink::WorkerThreadableLoader::WaitableEventWithTasks::wait()
#4 0x000003a858da blink::WorkerThreadableLoader::start()
#5 0x000003b2439e blink::WorkerScriptLoader::loadSynchronously()
#6 0x000003b1ccdd blink::WorkerGlobalScope::importScripts()
#7 0x0000032d55b0
blink::WorkerGlobalScopeV8Internal::importScriptsMethodCallback()
#8 0x000000c738ec v8::internal::FunctionCallbackArguments::Call()
#9 0x000000d04e3f v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#10 0x000000d03c95 v8::internal::Builtin_Impl_HandleApiCall()
#11 0x000000d0399e v8::internal::Builtin_HandleApiCall()
#12 0x3f31225063a7 <unknown>
  r8: 00007f7b32bf0700  r9: 00007f7b3d00c0d0 r10: 0000000004f9fd82 r11:
0000000000000000
 r12: 0000169403721ee0 r13: 00007f7b32bec7f0 r14: 00003410260a4d50 r15:
0000169403721ec8
  di: 0000000000000000  si: 0000000000000000  bp: 0000169403721f10  bx:
0000000006b00f40
  dx: 00007f7b3a7d5a80  ax: 00000000fbadbeef  cx: 000000000092cef0  sp:
00007f7b32bec490
  ip: 000000000493bd61 efl: 0000000000010246 cgf: 0000000000000033 erf:
0000000000000006
 trp: 000000000000000e msk: 0000000000000000 cr2: 00000000fbadbeef
[end of stack trace]
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000001f9258e base::debug::StackTrace::StackTrace()
#1 0x000001cad959 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7fba3095d0b0 <unknown>
#3 0x7fba30a1aa03 epoll_wait
#4 0x000002027bd8 epoll_dispatch
#5 0x0000020256f1 event_base_loop
#6 0x000001fb1006 base::MessagePumpLibevent::Run()
#7 0x000001fae011 base::MessageLoop::RunHandler()
#8 0x000001fcb270 base::RunLoop::Run()
#9 0x000001cc2ccc content::RunThisRunLoop()
#10 0x000001cc353c content::MessageLoopRunner::Run()
#11 0x000001cb0fc9 content::TitleWatcher::WaitAndGetTitle()
#12 0x00000078c876 content::WorkerTest::RunTest()
#13 0x00000078d1f2
content::WorkerTest_WorkerTlsClientAuth_Test::RunTestOnMainThread()
#14 0x000001ca8fd3 content::ContentBrowserTest::RunTestOnMainThreadLoop()
#15 0x000001cad6d9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#16 0x000001d02d92 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#17 0x0000017dc545 content::BrowserMainLoop::PreMainMessageLoopRun()
#18 0x000001b40a77 content::StartupTaskRunner::RunAllTasksNow()
#19 0x0000017daa74 content::BrowserMainLoop::CreateStartupTasks()
#20 0x0000017df41a content::BrowserMainRunnerImpl::Initialize()
#21 0x000001ceb4bc ShellBrowserMain()
#22 0x000001ce21d4 content::ShellMainDelegate::RunProcess()

[esprehn, 2016-08-29 23:05:06]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org

[esprehn, 2016-08-29 23:05:07]

haraken@ Got ideas? perhaps you could make this change? Having both
WaitableEvent and TaskSynchronizer is silly, we should merge them. :)

[haraken, 2016-08-30 00:09:47]

haraken@chromium.org changed reviewers:
+ keishi@chromium.org

[haraken, 2016-08-30 00:09:47]

On 2016/08/29 23:05:07, esprehn wrote:
> haraken@ Got ideas? perhaps you could make this change? Having both
> WaitableEvent and TaskSynchronizer is silly, we should merge them. :)

This is crashing because currently nested SafePointScope is not supported in
Oilpan. It wouldn't be that hard to support it though (e.g., we can just
introduce m_safePointNestedLevel or something). keishi-san?

The SafePointScope will be completely gone once we ship the per-thread heaps.

[commit-bot: I haz the power, 2016-08-30 03:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:42:14]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[keishi, 2016-08-30 10:56:19]

On 2016/08/30 00:09:47, haraken wrote:
> On 2016/08/29 23:05:07, esprehn wrote:
> > haraken@ Got ideas? perhaps you could make this change? Having both
> > WaitableEvent and TaskSynchronizer is silly, we should merge them. :)
> 
> This is crashing because currently nested SafePointScope is not supported in
> Oilpan. It wouldn't be that hard to support it though (e.g., we can just
> introduce m_safePointNestedLevel or something). keishi-san?
> 
> The SafePointScope will be completely gone once we ship the per-thread heaps.

Do we need to nest the SafePointScopes? Could we just remove the redundant
SafePoints like this?
https://codereview.chromium.org/2288983004/

[haraken, 2016-08-30 15:36:49]

On 2016/08/30 10:56:19, keishi wrote:
> On 2016/08/30 00:09:47, haraken wrote:
> > On 2016/08/29 23:05:07, esprehn wrote:
> > > haraken@ Got ideas? perhaps you could make this change? Having both
> > > WaitableEvent and TaskSynchronizer is silly, we should merge them. :)
> > 
> > This is crashing because currently nested SafePointScope is not supported in
> > Oilpan. It wouldn't be that hard to support it though (e.g., we can just
> > introduce m_safePointNestedLevel or something). keishi-san?
> > 
> > The SafePointScope will be completely gone once we ship the per-thread
heaps.
> 
> Do we need to nest the SafePointScopes? Could we just remove the redundant
> SafePoints like this?
> https://codereview.chromium.org/2288983004/

That's clever :) Let's land your CL.