Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp

Issue 2288973002: Merge TaskSynchronizer into WaitableEvent. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 11 matching lines...) Expand all
22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #include "platform/audio/HRTFDatabaseLoader.h" 29 #include "platform/audio/HRTFDatabaseLoader.h"
30 30
31 #include "platform/CrossThreadFunctional.h" 31 #include "platform/CrossThreadFunctional.h"
32 #include "platform/TaskSynchronizer.h" 32 #include "platform/WaitableEvent.h"
33 #include "public/platform/Platform.h" 33 #include "public/platform/Platform.h"
34 #include "public/platform/WebTaskRunner.h" 34 #include "public/platform/WebTaskRunner.h"
35 #include "public/platform/WebTraceLocation.h" 35 #include "public/platform/WebTraceLocation.h"
36 #include "wtf/PtrUtil.h" 36 #include "wtf/PtrUtil.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 using LoaderMap = HashMap<double, HRTFDatabaseLoader*>; 40 using LoaderMap = HashMap<double, HRTFDatabaseLoader*>;
41 41
42 // loaderMap() returns the static hash map that contains the mapping between the 42 // loaderMap() returns the static hash map that contains the mapping between the
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 MutexTryLocker tryLocker(m_lock); 114 MutexTryLocker tryLocker(m_lock);
115 115
116 if (!tryLocker.locked()) 116 if (!tryLocker.locked())
117 return nullptr; 117 return nullptr;
118 118
119 return m_hrtfDatabase.get(); 119 return m_hrtfDatabase.get();
120 } 120 }
121 121
122 // This cleanup task is needed just to make sure that the loader thread finishes 122 // This cleanup task is needed just to make sure that the loader thread finishes
123 // the load task and thus the loader thread doesn't touch m_thread any more. 123 // the load task and thus the loader thread doesn't touch m_thread any more.
124 void HRTFDatabaseLoader::cleanupTask(TaskSynchronizer* sync) 124 void HRTFDatabaseLoader::cleanupTask(WaitableEvent* sync)
125 { 125 {
126 sync->taskCompleted(); 126 sync->signal();
127 } 127 }
128 128
129 void HRTFDatabaseLoader::waitForLoaderThreadCompletion() 129 void HRTFDatabaseLoader::waitForLoaderThreadCompletion()
130 { 130 {
131 if (!m_thread) 131 if (!m_thread)
132 return; 132 return;
133 133
134 TaskSynchronizer sync; 134 WaitableEvent sync;
135 // TODO(alexclarke): Should this be posted as a loading task? 135 // TODO(alexclarke): Should this be posted as a loading task?
136 m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, crossThreadBind(&HRT FDatabaseLoader::cleanupTask, crossThreadUnretained(this), crossThreadUnretained (&sync))); 136 m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, crossThreadBind(&HRT FDatabaseLoader::cleanupTask, crossThreadUnretained(this), crossThreadUnretained (&sync)));
137 sync.waitForTaskCompletion(); 137 sync.wait();
138 m_thread.reset(); 138 m_thread.reset();
139 } 139 }
140 140
141 } // namespace blink 141 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.h ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698