Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2288823004: Merge 2277753006 into M54. (Closed)

Created:
4 years, 3 months ago by Azure Wei
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )" This reverts commit 7017855217bfc5d4ea11d44e526373bd7c571dac. Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production. Fix the underlying crash problem and add new test: ImeMenuTrayTest.QuitChromeWithMenuOpen to cover it. TBR=jamescook@chromium.org NOPRESUBMIT=true NOTRY=true BUG=640432 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2277753006 Cr-Commit-Position: refs/heads/master@{#414819} (cherry picked from commit c6200ab48ee282cae1460dfd1aaeafbf732897d6)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -13 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 6 chunks +23 lines, -12 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc View 4 chunks +105 lines, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ash/test/test_system_tray_delegate.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288823004/1
4 years, 3 months ago (2016-08-30 02:46:59 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-08-30 02:47:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288823004/1
4 years, 3 months ago (2016-08-30 03:45:50 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 03:56:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698