Chromium Code Reviews
DescriptionRevert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )"
This reverts commit 7017855217bfc5d4ea11d44e526373bd7c571dac.
Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production.
Fix the underlying crash problem and add new test:
ImeMenuTrayTest.QuitChromeWithMenuOpen
to cover it.
TBR=jamescook@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=640432
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2277753006
Cr-Commit-Position: refs/heads/master@{#414819}
(cherry picked from commit c6200ab48ee282cae1460dfd1aaeafbf732897d6)
Patch Set 1 #
Messages
Total messages: 10 (6 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||