Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2277753006: Revert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https:… (Closed)

Created:
4 years, 3 months ago by Azure Wei
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )" This reverts commit 7017855217bfc5d4ea11d44e526373bd7c571dac. Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production. Fix the underlying crash problem and add new test: ImeMenuTrayTest.QuitChromeWithMenuOpen to cover it. BUG=640432 TEST=Verified on local build. Committed: https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6 Cr-Commit-Position: refs/heads/master@{#414819}

Patch Set 1 #

Patch Set 2 : Fix the crash in test. #

Patch Set 3 : Add new test to cover the crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -13 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 1 2 6 chunks +23 lines, -12 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc View 1 2 4 chunks +105 lines, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ash/test/test_system_tray_delegate.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Azure Wei
Please review this cl. Thanks!
4 years, 3 months ago (2016-08-26 07:10:44 UTC) #11
James Cook
LGTM
4 years, 3 months ago (2016-08-26 15:52:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277753006/40001
4 years, 3 months ago (2016-08-26 21:36:09 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-26 21:42:54 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:46:02 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c6200ab48ee282cae1460dfd1aaeafbf732897d6
Cr-Commit-Position: refs/heads/master@{#414819}

Powered by Google App Engine
This is Rietveld 408576698