Issue 22887017: Revert "Throw an exception when denying access to 'Frame's 'location' setter."

Issue 22887017: Revert "Throw an exception when denying access to 'Frame's 'location' setter." (Closed)

Created:
7 years, 4 months ago by Alpha Left Google

Modified:
7 years, 4 months ago

Reviewers:
Use mkwst_at_chromium.org plz., Mike West

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Throw an exception when denying access to 'Frame's 'location' setter." This reverts commit r156151. This change seems to be causing unit test failing on Win 7 (dbg) bot. TBR=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156161

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -233 lines)			Patch
M	LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html	View	1 chunk	+28 lines, -27 lines	0 comments	Download
M	LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt	View	1 chunk	+3 lines, -6 lines	0 comments	Download
D	LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-uncaught.html	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-uncaught-expected.txt	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	Source/bindings/v8/BindingSecurity.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/BindingSecurity.cpp	View	3 chunks	+10 lines, -27 lines	0 comments	Download
M	Source/bindings/v8/ExceptionState.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/ExceptionState.cpp	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	Source/bindings/v8/ExceptionStatePlaceholder.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/ExceptionStatePlaceholder.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/bindings/v8/V8Initializer.cpp	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	Source/bindings/v8/V8ThrowException.h	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	Source/bindings/v8/V8ThrowException.cpp	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	Source/core/dom/DOMException.h	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	Source/core/dom/DOMException.cpp	View	2 chunks	+4 lines, -11 lines	0 comments	Download
M	Source/core/dom/ErrorEvent.h	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	Source/core/dom/ErrorEvent.cpp	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	Source/core/dom/ScriptExecutionContext.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/page/DOMWindow.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/DOMWindow.cpp	View	1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

Committed patchset #1 manually as r156161 (presubmit successful).

7 years, 4 months ago (2013-08-15 19:03:54 UTC) #1

Alpha Left Google

Please take a look at the failures: http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/11799 There's only change in the 3 that ...

7 years, 4 months ago (2013-08-15 19:06:38 UTC) #2

Use mkwst_at_chromium.org plz.

7 years, 4 months ago (2013-08-15 19:26:08 UTC) #3

Message was sent while issue was closed.

LGTM, thank you for reverting. I'll poke at this tomorrow, I suppose.

Expand Messages | Collapse Messages