Source/bindings/v8/BindingSecurity.h - Issue 22887017: Revert "Throw an exception when denying access to 'Frame's 'location' setter."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/BindingSecurity.h

Issue 22887017: Revert "Throw an exception when denying access to 'Frame's 'location' setter." (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-uncaught-expected.txt ('k') | Source/bindings/v8/BindingSecurity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/BindingSecurity.h

diff --git a/Source/bindings/v8/BindingSecurity.h b/Source/bindings/v8/BindingSecurity.h

index 8fba900cb7f9620df77d787598698da115ee9819..4387597b96df3713184c19b2be26769eb61104d2 100644

--- a/Source/bindings/v8/BindingSecurity.h

+++ b/Source/bindings/v8/BindingSecurity.h

@@ -36,8 +36,8 @@

namespace WebCore {

class DOMWindow;

-class ExceptionState;

class Frame;

+class HTMLFrameElementBase;

class Node;

enum SecurityReportingOption {

@@ -49,7 +49,7 @@ class BindingSecurity {

public:

static bool shouldAllowAccessToNode(Node*);

static bool shouldAllowAccessToFrame(Frame*, SecurityReportingOption = ReportSecurityError);

- static bool shouldAllowAccessToFrame(Frame*, ExceptionState&);

+ static bool allowSettingFrameSrcToJavascriptUrl(HTMLFrameElementBase*, const String& value);

};

}