Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2288563002: Treat implicit height on positioned objects as non-auto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 691734c6f921a96e44ac6dc707bae503e4cce547..b25780711fc6761580c9c819f41d7360a9e8d266 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -543,7 +543,8 @@ bool LayoutBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight(bool che
if (!checkingContainingBlock && thisBox->hasOverrideContainingBlockLogicalHeight())
return false;
}
- if (logicalHeightLength.isAuto())
+ bool isOutOfFlowPositionedWithImplicitHeight = isOutOfFlowPositioned() && !style()->logicalTop().isAuto() && !style()->logicalBottom().isAuto();
+ if (logicalHeightLength.isAuto() && !isOutOfFlowPositionedWithImplicitHeight)
mstensho (USE GERRIT) 2016/08/29 13:51:02 How about not evaluating "isOutOfFlowPositioned()
return true;
if (document().inQuirksMode())
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698