Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2288533002: Permission Action Reporting: Fix upload url. (Closed)

Created:
4 years, 3 months ago by kcarattini
Modified:
4 years, 3 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Permission Action Reporting: Fix upload url. BUG=641220, 613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Review-Url: https://codereview.chromium.org/2272793009 Cr-Original-Commit-Position: refs/heads/master@{#414637} Cr-Commit-Position: refs/heads/master@{#414652} (cherry picked from commit bdc8c79c3b29ee3299847cdb11e2c82d66138cff) Committed: https://chromium.googlesource.com/chromium/src/+/6baa09694b2f1e5341f11ff932a75df1d00ac1b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/safe_browsing/permission_reporter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/permission_reporter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kcarattini
Committed patchset #1 (id:1) manually as 6baa09694b2f1e5341f11ff932a75df1d00ac1b7.
4 years, 3 months ago (2016-08-27 22:17:47 UTC) #2
Nathan Parker
lgtm ( I often prefix the subject of merges like this with [Merge M54] so ...
4 years, 3 months ago (2016-08-29 16:10:08 UTC) #3
kcarattini
4 years, 3 months ago (2016-08-29 23:41:14 UTC) #4
Message was sent while issue was closed.
Thanks!

On 30 August 2016 at 02:10, <nparker@chromium.org> wrote:

> lgtm
>
> ( I often prefix the subject of merges like this with [Merge M54] so it's
> easy
> to understand why there are duplicate-looking CLs. )
>
>
> https://codereview.chromium.org/2288533002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698