Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2272793009:
Permission Action Reporting: Fix upload url. (Closed)
|
Created:
4 years, 3 months ago by kcarattini Modified:
4 years, 3 months ago Reviewers:
Nathan Parker CC:
chromium-reviews, grt+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPermission Action Reporting: Fix upload url.
BUG=641220, 613883
TBR=nparker@chromium.org
NOPRESUBMIT=true
NOTRY=true
Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c
Committed: https://crrev.com/bdc8c79c3b29ee3299847cdb11e2c82d66138cff
Cr-Original-Commit-Position: refs/heads/master@{#414637}
Cr-Commit-Position: refs/heads/master@{#414652}
Patch Set 1 #Patch Set 2 : Fix test as well #
Messages
Total messages: 22 (12 generated)
kcarattini@chromium.org changed reviewers: + nparker@chromium.org
Description was changed from ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 ========== to ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org ==========
The CQ bit was checked by kcarattini@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by kcarattini@chromium.org
Description was changed from ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org ========== to ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true ==========
The CQ bit was checked by kcarattini@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true ========== to ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true ========== to ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Cr-Commit-Position: refs/heads/master@{#414637} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Cr-Commit-Position: refs/heads/master@{#414637}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2279153002/ by haraken@chromium.org. The reason for reverting is: PermissionReporterTest.SendReport started failing on many bots after this CL: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2... .
Message was sent while issue was closed.
Description was changed from ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Cr-Commit-Position: refs/heads/master@{#414637} ========== to ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Cr-Commit-Position: refs/heads/master@{#414637} ==========
The CQ bit was checked by kcarattini@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Cr-Commit-Position: refs/heads/master@{#414637} ========== to ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Cr-Commit-Position: refs/heads/master@{#414637} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Cr-Commit-Position: refs/heads/master@{#414637} ========== to ========== Permission Action Reporting: Fix upload url. BUG=641220,613883 TBR=nparker@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c Committed: https://crrev.com/bdc8c79c3b29ee3299847cdb11e2c82d66138cff Cr-Original-Commit-Position: refs/heads/master@{#414637} Cr-Commit-Position: refs/heads/master@{#414652} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bdc8c79c3b29ee3299847cdb11e2c82d66138cff Cr-Commit-Position: refs/heads/master@{#414652}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
