chrome/browser/extensions/extension_keybinding_registry.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_keybinding_registry.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_keybinding_registry.cc

diff --git a/chrome/browser/extensions/extension_keybinding_registry.cc b/chrome/browser/extensions/extension_keybinding_registry.cc

index edc6bdef9195c344f63f1e4409dad6d01292d1a6..4a87ddd7b979d973fbe65aa169c1bddb39cf659d 100644

--- a/chrome/browser/extensions/extension_keybinding_registry.cc

+++ b/chrome/browser/extensions/extension_keybinding_registry.cc

@@ -71,7 +71,7 @@ void ExtensionKeybindingRegistry::CommandExecuted(

granter->GrantIfRequested(extension);

scoped_ptr<base::ListValue> args(new base::ListValue());

- args->Append(Value::CreateStringValue(command));

+ args->Append(new base::StringValue(command));

scoped_ptr<Event> event(new Event("commands.onCommand", args.Pass()));

event->restrict_to_profile = profile_;

« no previous file with comments | « chrome/browser/extensions/event_router.cc ('k') | chrome/browser/extensions/extension_override_apitest.cc » ('j') | no next file with comments »