chrome/browser/extensions/event_router.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/event_router.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/event_router.cc

diff --git a/chrome/browser/extensions/event_router.cc b/chrome/browser/extensions/event_router.cc

index f84b5f30bf97b89fd1ad6544bc15bcffa78c4918..0932d6c3215abb24d78bf09165a10c75db7f06d9 100644

--- a/chrome/browser/extensions/event_router.cc

+++ b/chrome/browser/extensions/event_router.cc

@@ -130,7 +130,7 @@ void EventRouter::DispatchExtensionMessage(IPC::Sender* ipc_sender,

}

ListValue args;

- args.Set(0, Value::CreateStringValue(event_name));

+ args.Set(0, new base::StringValue(event_name));

args.Set(1, event_args);

args.Set(2, info.AsValue().release());

ipc_sender->Send(new ExtensionMsg_MessageInvoke(

« no previous file with comments | « chrome/browser/extensions/convert_web_app.cc ('k') | chrome/browser/extensions/extension_keybinding_registry.cc » ('j') | no next file with comments »