Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: chrome/browser/extensions/convert_web_app.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/convert_user_script.cc ('k') | chrome/browser/extensions/event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/convert_web_app.cc
diff --git a/chrome/browser/extensions/convert_web_app.cc b/chrome/browser/extensions/convert_web_app.cc
index 5f844aba93fe6c56cdd8cd5d67cb59b7d42a5836..dc3d9469c9b5f9c0aa84072448e157f432b287ed 100644
--- a/chrome/browser/extensions/convert_web_app.cc
+++ b/chrome/browser/extensions/convert_web_app.cc
@@ -57,7 +57,7 @@ std::string GenerateKey(const GURL& manifest_url) {
return key;
}
-}
+} // namespace
// Generates a version for the converted app using the current date. This isn't
@@ -133,14 +133,14 @@ scoped_refptr<Extension> ConvertWebAppToExtension(
base::ListValue* permissions = new base::ListValue();
root->Set(keys::kPermissions, permissions);
for (size_t i = 0; i < web_app.permissions.size(); ++i) {
- permissions->Append(Value::CreateStringValue(web_app.permissions[i]));
+ permissions->Append(new base::StringValue(web_app.permissions[i]));
}
// Add the URLs.
base::ListValue* urls = new base::ListValue();
root->Set(keys::kWebURLs, urls);
for (size_t i = 0; i < web_app.urls.size(); ++i) {
- urls->Append(Value::CreateStringValue(web_app.urls[i].spec()));
+ urls->Append(new base::StringValue(web_app.urls[i].spec()));
}
// Write the manifest.
« no previous file with comments | « chrome/browser/extensions/convert_user_script.cc ('k') | chrome/browser/extensions/event_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698