Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2871)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 07cc111d178d2aa50822191c47206329a71451d4..565053ebb1dd39ee82b333bf4ad14ea6a5356161 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -357,34 +357,34 @@ void WebstorePrivateBeginInstallWithManifest3Function::SetResultCode(
ResultCode code) {
switch (code) {
case ERROR_NONE:
- SetResult(Value::CreateStringValue(std::string()));
+ SetResult(new base::StringValue(std::string()));
break;
case UNKNOWN_ERROR:
- SetResult(Value::CreateStringValue("unknown_error"));
+ SetResult(new base::StringValue("unknown_error"));
break;
case USER_CANCELLED:
- SetResult(Value::CreateStringValue("user_cancelled"));
+ SetResult(new base::StringValue("user_cancelled"));
break;
case MANIFEST_ERROR:
- SetResult(Value::CreateStringValue("manifest_error"));
+ SetResult(new base::StringValue("manifest_error"));
break;
case ICON_ERROR:
- SetResult(Value::CreateStringValue("icon_error"));
+ SetResult(new base::StringValue("icon_error"));
break;
case INVALID_ID:
- SetResult(Value::CreateStringValue("invalid_id"));
+ SetResult(new base::StringValue("invalid_id"));
break;
case PERMISSION_DENIED:
- SetResult(Value::CreateStringValue("permission_denied"));
+ SetResult(new base::StringValue("permission_denied"));
break;
case INVALID_ICON_URL:
- SetResult(Value::CreateStringValue("invalid_icon_url"));
+ SetResult(new base::StringValue("invalid_icon_url"));
break;
case SIGNIN_FAILED:
- SetResult(Value::CreateStringValue("signin_failed"));
+ SetResult(new base::StringValue("signin_failed"));
break;
case ALREADY_INSTALLED:
- SetResult(Value::CreateStringValue("already_installed"));
+ SetResult(new base::StringValue("already_installed"));
break;
default:
CHECK(false);
@@ -640,7 +640,7 @@ bool WebstorePrivateGetBrowserLoginFunction::RunImpl() {
}
bool WebstorePrivateGetStoreLoginFunction::RunImpl() {
- SetResult(Value::CreateStringValue(GetWebstoreLogin(profile_)));
+ SetResult(new base::StringValue(GetWebstoreLogin(profile_)));
return true;
}
@@ -662,7 +662,7 @@ WebstorePrivateGetWebGLStatusFunction::
~WebstorePrivateGetWebGLStatusFunction() {}
void WebstorePrivateGetWebGLStatusFunction::CreateResult(bool webgl_allowed) {
- SetResult(Value::CreateStringValue(
+ SetResult(new base::StringValue(
webgl_allowed ? "webgl_allowed" : "webgl_blocked"));
}
@@ -678,14 +678,14 @@ void WebstorePrivateGetWebGLStatusFunction::
}
bool WebstorePrivateGetIsLauncherEnabledFunction::RunImpl() {
- SetResult(Value::CreateBooleanValue(apps::IsAppLauncherEnabled()));
+ SetResult(new base::FundamentalValue(apps::IsAppLauncherEnabled()));
SendResponse(true);
return true;
}
bool WebstorePrivateIsInIncognitoModeFunction::RunImpl() {
SetResult(
- Value::CreateBooleanValue(profile_ != profile_->GetOriginalProfile()));
+ new base::FundamentalValue(profile_ != profile_->GetOriginalProfile()));
SendResponse(true);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698